Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: edf05350b9fb49af69ba20327ff7201f7b282979
https://github.com/WebKit/WebKit/commit/edf05350b9fb49af69ba20327ff7201f7b282979
Author: Dana Estra <[email protected]>
Date: 2024-04-24 (Wed, 24 Apr 2024)
Changed paths:
M Source/WebCore/Modules/modern-media-controls/controls/button.js
M
Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js
Log Message:
-----------
in in-window mode, video play/pauses when moving media controls
https://bugs.webkit.org/show_bug.cgi?id=273127
rdar://126300898
Reviewed by Jer Noble.
On youtube.com, the click event on the media controls propagates down to the
video element,
Where YouTube handles the event by toggling play/pause on the video. To fix
this, we do
Not want events on the media controls to propagate down. And so the call to
stopPropagation() on
The event should be moved from the button class to the
macOSFullscreenMediaControls class.
* Source/WebCore/Modules/modern-media-controls/controls/button.js:
(Button.prototype.handleEvent):
*
Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
(MacOSFullscreenMediaControls.prototype.handleEvent):
Canonical link: https://commits.webkit.org/277938@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
