Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f6ed29f91fc8f5d7fbde9c3d4a825b07dd6111fb
https://github.com/WebKit/WebKit/commit/f6ed29f91fc8f5d7fbde9c3d4a825b07dd6111fb
Author: Tim Nguyen <[email protected]>
Date: 2024-04-24 (Wed, 24 Apr 2024)
Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/dom/ViewTransition.h
M Source/WebCore/dom/ViewTransition.idl
Log Message:
-----------
[view-transitions] Clear view transition on navigation
https://bugs.webkit.org/show_bug.cgi?id=272792
rdar://126590072
Reviewed by Chris Dumez.
The VT crashtests were causing the following test to flakily crash. To fix
this, clear the view transition when the user navigates by
using ActiveDOMObject and defining a stop method.
Also protect the document in `ViewTransition::callUpdateCallback`.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::ViewTransition):
(WebCore::ViewTransition::create):
(WebCore::ViewTransition::skipViewTransition):
(WebCore::ViewTransition::callUpdateCallback):
(WebCore::ViewTransition::setupViewTransition):
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::captureNewState):
(WebCore::ViewTransition::setupTransitionPseudoElements):
(WebCore::ViewTransition::handleTransitionFrame):
(WebCore::ViewTransition::clearViewTransition):
(WebCore::ViewTransition::updatePseudoElementStyles):
(WebCore::ViewTransition::stop):
* Source/WebCore/dom/ViewTransition.h:
(WebCore::ViewTransition::document const):
(WebCore::ViewTransition::protectedDocument const):
* Source/WebCore/dom/ViewTransition.idl:
Canonical link: https://commits.webkit.org/277958@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
