Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b59055bbf3f5004e4b7d146a386ff6d33a2e86aa
      
https://github.com/WebKit/WebKit/commit/b59055bbf3f5004e4b7d146a386ff6d33a2e86aa
  Author: David Kilzer <[email protected]>
  Date:   2024-04-25 (Thu, 25 Apr 2024)

  Changed paths:
    M Configurations/Sanitizers.xcconfig

  Log Message:
  -----------
  Disable use-after-return checking to fix JSC GC on ASan builds
https://bugs.webkit.org/show_bug.cgi?id=273228
<rdar://126269133>

Reviewed by Mark Lam and Yusuke Suzuki.

Disable ASan use-after-return (UAR) checking at build time to prevent
false-positive use-after-free issues with the JavaScriptCore garbage
collector.  ASan uses a "fake stack" to allocate objects when UAR is
compiled in, but JSC doesn't know how to scan that memory, so it
incorrectly assumes that objects can be freed which are still alive.

* Configurations/Sanitizers.xcconfig:
(WK_SANITIZER_OTHER_LDFLAGS):
- Include OTHER_LDFLAGS when ASan is enabled.
(WK_ADDRESS_SANITIZER_OTHER_CFLAGS_YES):
(WK_ADDRESS_SANITIZER_OTHER_LDFLAGS_YES):
- Add `-fsanitize-address-use-after-return=never` argument.

Canonical link: https://commits.webkit.org/277993@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to