Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ffd9b9de8c8ae4f8b26b10e8ab966f64b3acc7ce
https://github.com/WebKit/WebKit/commit/ffd9b9de8c8ae4f8b26b10e8ab966f64b3acc7ce
Author: Tyler Wilcock <[email protected]>
Date: 2024-04-25 (Thu, 25 Apr 2024)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
Log Message:
-----------
AX: Remove several unused word, sentence, and paragraph position functions
https://bugs.webkit.org/show_bug.cgi?id=273206
rdar://problem/127000726
Reviewed by Chris Fleizach.
These functions were introduced before 2008:
https://github.com/WebKit/WebKit/commit/8486f1fe2dbeef8ae18aa9198fa56eebd3543a01#diff-e8db8bb19347472225640770719ab1678c0a95100df8cf27d1beb3a536717dcc
These functions stopped being called in these commits:
https://github.com/WebKit/WebKit/commit/9510dea2c8571c731e1450a64ebb77a4b415dabc
https://github.com/WebKit/WebKit/commit/8d97d59fcdf545e5cb25fbebb472e49b233256f2
https://github.com/WebKit/WebKit/commit/c67290aee69c9fd2fa709067c3f902e1d34ef912
(Commit titles are implement word / sentence / paragraph functionality using
TextIterator)
The attributes that were associated with these functions still exist and are
used, but now have a different implementation, e.g.:
if ([attribute
isEqualToString:AXPreviousSentenceStartTextMarkerForTextMarkerAttribute])
return (id)[self textMarkerForTextMarker:textMarker
atUnit:TextUnit::PreviousSentenceStart];
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::positionOfLeftWord const): Deleted.
(WebCore::AccessibilityObject::positionOfRightWord const): Deleted.
(WebCore::AccessibilityObject::sentenceForPosition const): Deleted.
(WebCore::AccessibilityObject::paragraphForPosition const): Deleted.
(WebCore::AccessibilityObject::nextSentenceEndPosition const): Deleted.
(WebCore::AccessibilityObject::previousSentenceStartPosition const): Deleted.
(WebCore::AccessibilityObject::nextParagraphEndPosition const): Deleted.
(WebCore::AccessibilityObject::previousParagraphStartPosition const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::nextSentenceEndPosition const): Deleted.
(WebCore::AXIsolatedObject::previousSentenceStartPosition const): Deleted.
(WebCore::AXIsolatedObject::nextParagraphEndPosition const): Deleted.
(WebCore::AXIsolatedObject::previousParagraphStartPosition const): Deleted.
(WebCore::AXIsolatedObject::positionOfLeftWord const): Deleted.
(WebCore::AXIsolatedObject::positionOfRightWord const): Deleted.
(WebCore::AXIsolatedObject::sentenceForPosition const): Deleted.
(WebCore::AXIsolatedObject::paragraphForPosition const): Deleted.
(WebCore::AXIsolatedObject::visiblePositionRangeForRange const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
Canonical link: https://commits.webkit.org/278019@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes