Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 95e791e34021f963c6c7dff0103d3b0eb924da2a
      
https://github.com/WebKit/WebKit/commit/95e791e34021f963c6c7dff0103d3b0eb924da2a
  Author: Tyler Wilcock <[email protected]>
  Date:   2024-04-25 (Thu, 25 Apr 2024)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_text_node-expected.txt
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp

  Log Message:
  -----------
  AX: WebKit should not trim non-breaking space characters when computing 
accessibility text
https://bugs.webkit.org/show_bug.cgi?id=273292
rdar://problem/127084721

Reviewed by Andres Gonzalez.

In https://bugs.webkit.org/show_bug.cgi?id=271896, we replaced usage of 
deprecatedIsSpaceOrNewline with isUnicodeWhitespace.
Importantly, isUnicodeWhitespace trims non-breaking space characters, which is 
not the correct thing to do when computing
accessibility text (we should only trim ASCII whitespace).

* 
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_text_node-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityNodeObject::textAsLabelFor const):
(WebCore::AccessibilityNodeObject::textUnderElement const):
(WebCore::accessibleNameForNode):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::stringForRange const):

Canonical link: https://commits.webkit.org/278028@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to