Branch: refs/heads/webkitglib/2.44
Home: https://github.com/WebKit/WebKit
Commit: 79ad68e7086aff98073fe99e3e9d53e20a3bb41e
https://github.com/WebKit/WebKit/commit/79ad68e7086aff98073fe99e3e9d53e20a3bb41e
Author: Olivier Blin <[email protected]>
Date: 2024-04-27 (Sat, 27 Apr 2024)
Changed paths:
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp
Log Message:
-----------
Cherry-pick 275228@main (a216dd6f98bf).
https://bugs.webkit.org/show_bug.cgi?id=269913
[WPE][GTK] Fully disable mDNS LibWebRTC support
https://bugs.webkit.org/show_bug.cgi?id=269913
Reviewed by Philippe Normand.
In 275090@main (c62c74690915), mDNS LibWebRTC support has been disabled
for WPE and GTK in LibWebRTCNetworkManager::GetMdnsResponder().
But this is not synchronized with WebRTCProvider::isSupportingMDNS(),
which is used to initialize m_shouldFilterICECandidates in
PeerConnectionBackend::PeerConnectionBackend().
This triggers assertions in PeerConnectionBackend::newICECandidate().
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCProvider::LibWebRTCProvider):
Canonical link: https://commits.webkit.org/275228@main
Canonical link: https://commits.webkit.org/274313.167@webkitglib/2.44
Commit: 4746fa7ce6f922558e2b0f0c2a1a33464d823e38
https://github.com/WebKit/WebKit/commit/4746fa7ce6f922558e2b0f0c2a1a33464d823e38
Author: Olivier Blin <[email protected]>
Date: 2024-04-27 (Sat, 27 Apr 2024)
Changed paths:
M
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp
Log Message:
-----------
Cherry-pick 275235@main (91dc14fd908d).
https://bugs.webkit.org/show_bug.cgi?id=269915
[GStreamer][LibWebRTC] Conflict between two GStreamerVideoDecoder classes
can lead to crash
https://bugs.webkit.org/show_bug.cgi?id=269915
Reviewed by Philippe Normand.
In the GStreamer ports, there are two different implementations of the
WebCore::GStreamerVideoDecoder class:
- one for WebRTC in
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp
- one for WebCodecs in
Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp
This can lead to a crash in WebRTC usage, since the
WebCore::GStreamerVideoDecoder destructor from the WebCodecs class can
be mistakenly used instead of the one from the WebRTC class.
Rename the WebRTC class as GStreamerWebRTCVideoDecoder.
*
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
(WebCore::GStreamerWebRTCVideoDecoder::GStreamerWebRTCVideoDecoder):
(WebCore::GStreamerVideoDecoder::GStreamerVideoDecoder): Deleted.
(WebCore::GStreamerVideoDecoder::decodebinPadAddedCb): Deleted.
(WebCore::GStreamerVideoDecoder::pipeline): Deleted.
(WebCore::GStreamerVideoDecoder::makeElement): Deleted.
(WebCore::GStreamerVideoDecoder::handleError): Deleted.
(WebCore::GStreamerVideoDecoder::CreateFilter): Deleted.
(WebCore::GStreamerVideoDecoder::pullSample): Deleted.
(WebCore::GStreamerVideoDecoder::GetCapsForFrame): Deleted.
(WebCore::GStreamerVideoDecoder::AddDecoderIfSupported): Deleted.
(WebCore::GStreamerVideoDecoder::ConfigureSupportedDecoder): Deleted.
(WebCore::GStreamerVideoDecoder::GstDecoderFactory): Deleted.
(WebCore::GStreamerVideoDecoder::HasGstDecoder): Deleted.
Canonical link: https://commits.webkit.org/275235@main
Canonical link: https://commits.webkit.org/274313.168@webkitglib/2.44
Compare: https://github.com/WebKit/WebKit/compare/40ff10f0156b...4746fa7ce6f9
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
