Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 44488b037c9b367b57bd00943194c42b46c20eee
https://github.com/WebKit/WebKit/commit/44488b037c9b367b57bd00943194c42b46c20eee
Author: Andy Estes <[email protected]>
Date: 2024-04-28 (Sun, 28 Apr 2024)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/PageClientImplIOS.h
M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
M Source/WebKit/UIProcess/mac/PageClientImplMac.h
Log Message:
-----------
[visionOS] After returning to element fullscreen from LMK fullscreen, unable
to re-enter LMK fullscreen
https://bugs.webkit.org/show_bug.cgi?id=273344
rdar://127137182
Reviewed by Eric Carlson.
When exiting LinearMediaKit fullscreen the VideoPresentationInterfaceLMK and its
LMPlayableViewController are destroyed, but WKFullScreenViewController still
has a reference to a
UIView created by the LMPlayableViewController. Since the
LMPlayableViewController and its
Playable-conforming delegate no longer exist, the view has no delegate to
notify when the user
interacts with it. This results in an inability to re-enter LinearMediaKit
fullscreen after
previously exiting from it to element fullscreen.
Resolved this by plumbing a "didCleanupFullscreen" call from
VideoPresentationInterfaceIOS to
WKFullScreenViewController. When this method is called and the VC is still in
fullscreen mode,
WKFullScreenViewController is told to remove the old
_environmentPickerButtonView and create a new
one (which will re-ensure a VideoPresentationInterfaceLMK and
LMPlayableViewController).
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::didCleanupFullscreen):
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCleanupFullscreen):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didCleanupFullscreen):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController configureEnvironmentPickerButtonView]):
(-[WKFullScreenViewController
_configureEnvironmentPickerButtonViewWithPlayableViewController:]): Deleted.
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController didCleanupFullscreen]):
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:
Canonical link: https://commits.webkit.org/278089@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
