Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1bc81c31ff6c5f2b535b70b44de1ebc5e0389725
https://github.com/WebKit/WebKit/commit/1bc81c31ff6c5f2b535b70b44de1ebc5e0389725
Author: Carlos Bentzen <[email protected]>
Date: 2024-04-29 (Mon, 29 Apr 2024)
Changed paths:
A
LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver-expected.txt
A
LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver.html
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
Log Message:
-----------
[WebRTC][GStreamer] Missing media in SDP if setConfiguration() is called
after createDataChannel() or addTransceiver()
https://bugs.webkit.org/show_bug.cgi?id=273318
Reviewed by Xabier Rodriguez-Calvar.
GStreamerMediaEndpoint::setConfiguration() was tearing down the pipeline
if one already existed and creating a new one, which is an issue if any data
channels
or transceivers are created before RTCPeerConnection.setConfiguration().
The issue is fixed by creating the pipeline earlier in GStreamerMediaEndpoint's
contructor,
so that data channels or transceivers aren't discarded if created/added before
setConfiguration().
Credit to Philippe Normand <[email protected]> for finding the issue and fixing
it.
I wrote the layout test, which fails without his fix.
*
LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver-expected.txt:
Added.
*
LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver.html:
Added.
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::GStreamerMediaEndpoint):
(WebCore::GStreamerMediaEndpoint::setConfiguration):
Canonical link: https://commits.webkit.org/278099@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
