Title: [110773] trunk/Source/WebKit/chromium
Revision
110773
Author
[email protected]
Date
2012-03-14 15:58:18 -0700 (Wed, 14 Mar 2012)

Log Message

[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
https://bugs.webkit.org/show_bug.cgi?id=80523

Reviewed by Darin Fisher.

* public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::createGraphicsContext3D):
* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (110772 => 110773)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-03-14 22:56:15 UTC (rev 110772)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-03-14 22:58:18 UTC (rev 110773)
@@ -1,5 +1,20 @@
 2012-03-14  James Robinson  <[email protected]>
 
+        [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
+        https://bugs.webkit.org/show_bug.cgi?id=80523
+
+        Reviewed by Darin Fisher.
+
+        * public/WebViewClient.h:
+        (WebViewClient):
+        (WebKit::WebViewClient::createGraphicsContext3D):
+        * public/platform/WebKitPlatformSupport.h:
+        (WebKit):
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::createCompositorGraphicsContext3D):
+
+2012-03-14  James Robinson  <[email protected]>
+
         [chromium] Remove canRecoverFromContextLoss attribute, it's unused
         https://bugs.webkit.org/show_bug.cgi?id=81158
 

Modified: trunk/Source/WebKit/chromium/public/WebViewClient.h (110772 => 110773)


--- trunk/Source/WebKit/chromium/public/WebViewClient.h	2012-03-14 22:56:15 UTC (rev 110772)
+++ trunk/Source/WebKit/chromium/public/WebViewClient.h	2012-03-14 22:58:18 UTC (rev 110773)
@@ -116,8 +116,6 @@
     // Creates a graphics context that renders to the client's WebView.
     virtual WebGraphicsContext3D* createGraphicsContext3D(const WebGraphicsContext3D::Attributes&) { return 0; }
 
-    // Deprecated, use the first version of this function. If you want an offscreen context, use WebKitPlatformSupport::createOffscreenGraphicsContext3D().
-    virtual WebGraphicsContext3D* createGraphicsContext3D(const WebGraphicsContext3D::Attributes&, bool renderDirectlyToWebView) { return 0; }
 
     // Misc ----------------------------------------------------------------
 

Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (110772 => 110773)


--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-03-14 22:56:15 UTC (rev 110772)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h	2012-03-14 22:58:18 UTC (rev 110773)
@@ -386,6 +386,11 @@
     // Returns newly allocated and initialized offscreen WebGraphicsContext3D instance.
     virtual WebGraphicsContext3D* createOffscreenGraphicsContext3D(const WebGraphicsContext3D::Attributes&) { return 0; }
 
+    // Returns true if the platform is capable of producing an offscreen context suitable for accelerating 2d canvas.
+    // This will return false if the platform cannot promise that contexts will be preserved across operations like
+    // locking the screen or if the platform cannot provide a context with suitable performance characteristics.
+    //
+    // This value must be checked again after a context loss event as the platform's capabilities may have changed.
     virtual bool canAccelerate2dCanvas() { return false; }
 
     // Audio --------------------------------------------------------------
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to