Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1e8820b0c20a1b94809b4102358134d09e335508
https://github.com/WebKit/WebKit/commit/1e8820b0c20a1b94809b4102358134d09e335508
Author: Jonathan Bedard <[email protected]>
Date: 2024-04-30 (Tue, 30 Apr 2024)
Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
M Tools/Scripts/webkitpy/port/test.py
Log Message:
-----------
[DumpRenderTree] Off-by-1 failure after running fonts on macOS
https://bugs.webkit.org/show_bug.cgi?id=273212
rdar://121476009
Reviewed by Sam Sneddon.
If a ref test doesn't generate an image, the driver is in an undefined state.
One possibility is that
we considered the driver "finished" before waiting for it's output. If that is
true, we can possibly
cause every subsequent test run by this worker to fail.
* LayoutTests/platform/mac-wk1/TestExpectations: Skip only
fonts/font-fallback-prefers-pictographs.html,
since that test occasionally crashes DumpRenderTree.
* LayoutTests/platform/mac-wk2/TestExpectations: Skip
fast/forms/select/mac-wk2/inactive-appearance.html.
* Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._run_reftest): If a ref test doesn't generate any output,
don't attempt to run the
baseline and kill the driver.
* Tools/Scripts/webkitpy/port/test.py:
(TestDriver.__init__): Add a 'is_valid_state', which is reset by 'stop'.
(TestDriver.run_test): If a test is a ref test but doesn't produce an image,
set 'is_valid_state' to 'False'.
This is an attempt to mock a bug in DumpRenderTree where a ref test returns an
empty output initially and the
actual output on the subsequent test.
(TestDriver.stop): Reset 'is_valid_state' to 'True'.
Canonical link: https://commits.webkit.org/278180@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
