Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 393949a1c17caf79bfdab86b7b0a5fc9cf603ea9
https://github.com/WebKit/WebKit/commit/393949a1c17caf79bfdab86b7b0a5fc9cf603ea9
Author: Nicole Rosario <[email protected]>
Date: 2024-04-30 (Tue, 30 Apr 2024)
Changed paths:
A
LayoutTests/ipc/send-gpu-GetShareableBitmap-RemoteRenderingBackend-expected.txt
A LayoutTests/ipc/send-gpu-GetShareableBitmap-RemoteRenderingBackend.html
M Source/WebCore/Headers.cmake
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/graphics/ImageBuffer.cpp
M Source/WebCore/platform/graphics/ImageBuffer.h
A Source/WebCore/platform/graphics/PixelFormatValidated.cpp
A Source/WebCore/platform/graphics/PixelFormatValidated.h
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h
M Tools/TestWebKitAPI/Tests/WebCore/DisplayListRecorderTests.cpp
Log Message:
-----------
Assert hit in WebKit::RemoteImageBuffer::getShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=273285
rdar://122378565
Reviewed by Alex Christensen.
The `IPC.messages.RemoteRenderingBackend_CreateImageBuffer` was able to send
PixelFormat
values that are not valid and therefore caused a crash. Added an enum for only
the valid
PixelFormat values so that only valid values can be sent over IPC
*
LayoutTests/ipc/send-gpu-GetShareableBitmap-RemoteRenderingBackend-expected.txt:
Added.
* LayoutTests/ipc/send-gpu-GetShareableBitmap-RemoteRenderingBackend.html:
Added.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::backendParameters):
* Source/WebCore/platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
(WebCore::ImageBuffer::pixelFormatValidated const):
(WebCore::ImageBuffer::pixelFormat const): Deleted.
* Source/WebCore/platform/graphics/PixelFormatValidated.cpp: Added.
(WebCore::convertPixelFormatToPixelFormatValidated):
(WebCore::convertPixelFormatValidatedToPixelFormat):
* Source/WebCore/platform/graphics/PixelFormatValidated.h: Added.
* Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp:
(WebKit::RemoteImageBuffer::getShareableBitmap):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::isSmallLayerBacking):
(WebKit::allocateImageBufferInternal):
(WebKit::RemoteRenderingBackend::createImageBuffer):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp:
(WebKit::RemoteImageBufferProxy::sinkIntoBufferForDifferentThread):
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
(WebKit::RemoteImageBufferProxy::create):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):
(WebKit::RemoteRenderingBackendProxy::createDisplayListRecorder):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
* Tools/TestWebKitAPI/Tests/WebCore/DisplayListRecorderTests.cpp:
(TestWebKitAPI::createTestImageBuffer):
Canonical link: https://commits.webkit.org/278192@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
