Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f069b9d3124d91b6e537be45ea349b79388895f5 https://github.com/WebKit/WebKit/commit/f069b9d3124d91b6e537be45ea349b79388895f5 Author: Gerald Squelart <g_squel...@apple.com> Date: 2024-05-01 (Wed, 01 May 2024)
Changed paths: M Source/WTF/wtf/StackTrace.h M Source/WebCore/html/HTMLAttachmentElement.cpp Log Message: ----------- Log attachment editing operations https://bugs.webkit.org/show_bug.cgi?id=270152 rdar://121088022 Reviewed by Wenson Hsieh and Aditya Keerthi. This is for Mail to know when and why an attachment was quickly inserted, removed, then another attachment was inserted, all soon after the document creation; this seems to correlate with unexpected behavior where an attachment cannot be inserted in an email reply. When this quick sequence happens, compact stacks are logged for each event, in the "Editing" category. Example: ``` HTMLAttachmentElement - quick insert(A)-remove(A)-insert(B) within 0.074342s of the first document[0x116122400] load, stacks below: HTMLAttachmentElement[0x117006530 uuid=47a8d676-657f-4510-a8f3-5cb9723b0947] - 1st insertion 108.248833ms ago: [stack] HTMLAttachmentElement[0x117006530 uuid=47a8d676-657f-4510-a8f3-5cb9723b0947] - removal 4.043792ms ago: [stack] HTMLAttachmentElement[0x11700ba30 uuid=47a8d676-657f-4510-a8f3-5cb9723b0947] - 2nd insertion: [stack] ``` * Source/WTF/wtf/StackTrace.h: (WTF::StackTrace::forEachFrame const): * Source/WebCore/html/HTMLAttachmentElement.cpp: (WebCore::compactStackTrace): (WebCore::AttachmentEvent::attachment const): (WebCore::AttachmentEvent::document const): (WebCore::AttachmentEvent::uniqueIdentifier const): (WebCore::AttachmentEvent::time const): (WebCore::AttachmentEvent::stackTrace const): (WebCore::AttachmentEvent::capture): (WebCore::AttachmentEvent::reset): (WebCore::AttachmentEvent::operator bool const): (WebCore::lastInsertionInDocument): (WebCore::lastRemovalFromDocument): (WebCore::shouldMonitorDocumentTraffic): (WebCore::HTMLAttachmentElement::insertedIntoAncestor): (WebCore::HTMLAttachmentElement::removedFromAncestor): Canonical link: https://commits.webkit.org/278245@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes