Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8251b5c26b6d9ddd3ac1268c2d8c7940094a49af
https://github.com/WebKit/WebKit/commit/8251b5c26b6d9ddd3ac1268c2d8c7940094a49af
Author: Erica Li <[email protected]>
Date: 2024-05-04 (Sat, 04 May 2024)
Changed paths:
A
LayoutTests/fast/css-grid-layout/out-of-flow-positioned-dialog-showModal-crash-expected.txt
A
LayoutTests/fast/css-grid-layout/out-of-flow-positioned-dialog-showModal-crash.html
M Source/WebCore/dom/FullscreenManager.cpp
M Source/WebCore/html/HTMLDialogElement.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
Log Message:
-----------
ASAN_SEGV | WebCore::RenderFragmentedFlow::objectShouldFragmentInFlowFragment.
rdar://125183911
https://bugs.webkit.org/show_bug.cgi?id=272301
Reviewed by Alan Baradlay.
This is another case where we can not dectect containing block change
in styledid/willchange like what was fixed in 266309@main,
moved markRendererDirtyAfterTopLayerChange to Element as common API
which can be used by FullscreenManager and HTMLDialogElement.
*
LayoutTests/fast/css-grid-layout/out-of-flow-positioned-dialog-showModal-crash-expected.txt:
Added.
*
LayoutTests/fast/css-grid-layout/out-of-flow-positioned-dialog-showModal-crash.html:
Added.
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::markRendererDirtyAfterTopLayerChange): Deleted.
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::showModal):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::gridStyleHasNotChanged): mini refactoring to make criteria looks more
clear.
(WebCore::RenderBox::updateGridPositionAfterStyleChange):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::markRendererDirtyAfterTopLayerChange):
* Source/WebCore/rendering/RenderElement.h:
Canonical link: https://commits.webkit.org/278372@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
