Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 88ff63ad3bde35abf2ae32a3136cbe2ac6289dc0
https://github.com/WebKit/WebKit/commit/88ff63ad3bde35abf2ae32a3136cbe2ac6289dc0
Author: Eric Carlson <eric.carl...@apple.com>
Date: 2024-05-05 (Sun, 05 May 2024)
Changed paths:
M Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.h
M Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.mm
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm
Log Message:
-----------
Do not trigger stream configuration updates in case user is capturing screen
in large presenter overlay mode
Do not trigger stream configuration updates in case user is capturing screen in
large presenter overlay mode
https://bugs.webkit.org/show_bug.cgi?id=273684
rdar://125925090
Reviewed by Eric Carlson.
We enter in a loop of reconfiguration when trying to update the stream
configuration size when user selects large presenter overlay mode.
We are now skipping the reconfiguration step.
This reintroduces black stripes like there used to have before rdar://124131045.
A future patch will fix this by adding cropping within
ScreenCaptureKitCaptureSource.
We detect large presenter overlay mode by:
- detecting whether video effect is enabled (which means presenter mode is on
or off)
- detecting whether the overlay rectangle (showing the screen content) origin
is filled with valid values.
Manually tested.
* Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.h:
* Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.mm:
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(-[WebCoreScreenCaptureKitHelper outputVideoEffectDidStartForStream:]):
(-[WebCoreScreenCaptureKitHelper outputVideoEffectDidStopForStream:]):
(WebCore::ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer):
Canonical link: https://commits.webkit.org/278390@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
