Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fd2cfc0030266cf4914ed09116b2fbd745662985
https://github.com/WebKit/WebKit/commit/fd2cfc0030266cf4914ed09116b2fbd745662985
Author: Erica Li <[email protected]>
Date: 2024-05-16 (Thu, 16 May 2024)
Changed paths:
A
LayoutTests/fast/text/splitText-crash-during-tear-down-renderers-after-slot-change-expected.txt
A
LayoutTests/fast/text/splitText-crash-during-tear-down-renderers-after-slot-change.html
M Source/WebCore/editing/SplitTextNodeContainingElementCommand.cpp
Log Message:
-----------
ASAN_TRAP | WebCore::RenderObject::~RenderObject;
WebCore::RenderInline::~RenderInline.
https://bugs.webkit.org/show_bug.cgi?id=269667
rdar://122491721
Reviewed by Ryosuke Niwa and Chris Dumez.
Reduce the scope of CheckedPtr renderer in
`SplitTextNodeContainingElementCommand::doApply`,
as following `splitElement` could destruct renderer.
*
LayoutTests/fast/text/splitText-crash-during-tear-down-renderers-after-slot-change-expected.txt:
Added.
*
LayoutTests/fast/text/splitText-crash-during-tear-down-renderers-after-slot-change.html:
Added.
* Source/WebCore/editing/SplitTextNodeContainingElementCommand.cpp:
(WebCore::SplitTextNodeContainingElementCommand::doApply):
Originally-landed-as: 272448.580@safari-7618-branch (3dc4ac46465e).
rdar://128215842
Canonical link: https://commits.webkit.org/278897@main
Commit: 83a9a0ad6917ef3d6002b5123cc42d7dd847a9b6
https://github.com/WebKit/WebKit/commit/83a9a0ad6917ef3d6002b5123cc42d7dd847a9b6
Author: Erica Li <[email protected]>
Date: 2024-05-16 (Thu, 16 May 2024)
Changed paths:
M
LayoutTests/fast/text/splitText-crash-during-tear-down-renderers-after-slot-change.html
Log Message:
-----------
Fix flakey splitText-crash-during-tear-down-renderers-after-slot-change.
rdar://125264773
Reviewed by Jonathan Bedard.
Fix text difference on some release builds.
*
LayoutTests/fast/text/splitText-crash-during-tear-down-renderers-after-slot-change.html:
Originally-landed-as: 272448.780@safari-7618-branch (c57347c1c44f).
rdar://128088552
Canonical link: https://commits.webkit.org/278898@main
Compare: https://github.com/WebKit/WebKit/compare/4f5aa1a1182d...83a9a0ad6917
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
