Title: [110884] trunk/Source/WebCore
Revision
110884
Author
[email protected]
Date
2012-03-15 14:07:49 -0700 (Thu, 15 Mar 2012)

Log Message

Assertion failures in WebCore::Page::goBackOrForward causing multiple "crashes" on Lion Intel
Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81159

Rubber-stamped by Brady Eidson.

It is plausible that history could change in between the time a navigation request is
scheduled and the timer is fired, so the request index could be out of the b/f list range.
Hence, the assertion is invalid and should be removed.

* page/Page.cpp:
(WebCore::Page::goBackOrForward):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (110883 => 110884)


--- trunk/Source/WebCore/ChangeLog	2012-03-15 21:07:37 UTC (rev 110883)
+++ trunk/Source/WebCore/ChangeLog	2012-03-15 21:07:49 UTC (rev 110884)
@@ -1,3 +1,18 @@
+2012-03-15  Jessie Berlin  <[email protected]>
+
+        Assertion failures in WebCore::Page::goBackOrForward causing multiple "crashes" on Lion Intel
+        Debug WebKit2 testers
+        https://bugs.webkit.org/show_bug.cgi?id=81159
+
+        Rubber-stamped by Brady Eidson.
+
+        It is plausible that history could change in between the time a navigation request is
+        scheduled and the timer is fired, so the request index could be out of the b/f list range.
+        Hence, the assertion is invalid and should be removed.
+
+        * page/Page.cpp:
+        (WebCore::Page::goBackOrForward):
+
 2012-03-15  Alexey Proskuryakov  <[email protected]>
 
         Assertion failures in checkEncodedString when running WebKit2 tests

Modified: trunk/Source/WebCore/page/Page.cpp (110883 => 110884)


--- trunk/Source/WebCore/page/Page.cpp	2012-03-15 21:07:37 UTC (rev 110883)
+++ trunk/Source/WebCore/page/Page.cpp	2012-03-15 21:07:49 UTC (rev 110884)
@@ -324,7 +324,6 @@
         }
     }
 
-    ASSERT(item);
     if (!item)
         return;
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to