Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f158fce2282ed8ee934e847cfade3bc7621969f
      
https://github.com/WebKit/WebKit/commit/4f158fce2282ed8ee934e847cfade3bc7621969f
  Author: Charlie Wolfe <[email protected]>
  Date:   2024-05-26 (Sun, 26 May 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/mac/KeyboardEventTests.mm
    M Tools/TestWebKitAPI/Tests/mac/MouseEventTests.mm

  Log Message:
  -----------
  REGRESSION(278568@main): UI process crash when event replies are received 
during process termination
https://bugs.webkit.org/show_bug.cgi?id=274688
rdar://128236488

Reviewed by Chris Dumez.

After 278568@main, if mouse/key event replies are received after web process 
termination has begun but
its `WebProcessProxy` has not been destructed, we try to dequeue from an empty 
queue. We should not try
to dequeue events if the current process is being terminated, because the 
events queues will have already
been cleared.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendMouseEvent):
(WebKit::WebPageProxy::sendKeyEvent):
* Tools/TestWebKitAPI/Tests/mac/KeyboardEventTests.mm:
(TestWebKitAPI::TEST(KeyboardEventTests, 
TerminateWebContentProcessDuringKeyEventHandling)):
* Tools/TestWebKitAPI/Tests/mac/MouseEventTests.mm:
(TestWebKitAPI::TEST(MouseEventTests, 
TerminateWebContentProcessDuringMouseEventHandling)):

Canonical link: https://commits.webkit.org/279333@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to