Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5dceca812aa0bab38c7a52a10b6368e10f162c7d
https://github.com/WebKit/WebKit/commit/5dceca812aa0bab38c7a52a10b6368e10f162c7d
Author: Mike Wyrzykowski <[email protected]>
Date: 2024-05-28 (Tue, 28 May 2024)
Changed paths:
A LayoutTests/fast/webgpu/regression/repro_274706-expected.txt
A LayoutTests/fast/webgpu/regression/repro_274706.html
A LayoutTests/fast/webgpu/regression/repro_274706b-expected.txt
A LayoutTests/fast/webgpu/regression/repro_274706b.html
A LayoutTests/fast/webgpu/regression/repro_274706c-expected.txt
A LayoutTests/fast/webgpu/regression/repro_274706c.html
M Source/WebGPU/WebGPU/Pipeline.mm
M Source/WebGPU/WebGPU/PipelineLayout.h
M Source/WebGPU/WebGPU/PipelineLayout.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/RenderPipeline.h
M Source/WebGPU/WebGPU/RenderPipeline.mm
Log Message:
-----------
[WebGPU] Bind groups skip validation in some cases
https://bugs.webkit.org/show_bug.cgi?id=274706
<radar://128673122>
Reviewed by Tadeu Zagallo.
Bind group validation was being skipped by the number of vertex buffers
a pipeline used.
RenderPipeline::vertexStageInBufferCount() was not needed at all since
the validation is handled by RenderPipeline::requiredBufferIndices().
* LayoutTests/fast/webgpu/regression/repro_274706-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274706.html: Added.
* LayoutTests/fast/webgpu/regression/repro_274706b-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274706b.html: Added.
* LayoutTests/fast/webgpu/regression/repro_274706c-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274706c.html: Added.
Add regression tests.
* Source/WebGPU/WebGPU/PipelineLayout.h:
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::PipelineLayout::errorValidatingBindGroupCompatibility const):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPipeline.h:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::vertexStageInBufferCount const): Deleted.
Canonical link: https://commits.webkit.org/279403@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes