Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4af8f052cd4fee2c1f169220ab61ed94f512d0ff
https://github.com/WebKit/WebKit/commit/4af8f052cd4fee2c1f169220ab61ed94f512d0ff
Author: Ahmad Saleem <[email protected]>
Date: 2024-05-28 (Tue, 28 May 2024)
Changed paths:
A
LayoutTests/fast/inline/continuation-inlines-inserted-in-reverse-after-block-expected.txt
A
LayoutTests/fast/inline/continuation-inlines-inserted-in-reverse-after-block.html
M LayoutTests/platform/glib/tables/mozilla/bugs/bug113235-3-expected.txt
M LayoutTests/platform/ios/tables/mozilla/bugs/bug113235-3-expected.txt
M LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-3-expected.png
M LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-3-expected.txt
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
Log Message:
-----------
Fix render tree construction when inlines are inserted in reverse after a
block in a continuation
https://bugs.webkit.org/show_bug.cgi?id=274762
rdar://problem/128826228
Reviewed by Darin Adler.
This patch aligns WebKit with Blink / Chromium and
Gecko / Firefox.
Merge:
https://chromium.googlesource.com/chromium/blink/+/6ac676e5e68e3271321b9c8236192b6a530d055e
When inserting inlines after a block inside of an inline continuation,
if we insert inline content in reverse DOM order, we can (depending on
when we attach) end up appending the renderers in the wrong location,
leading to visual aberrations.
The fix is in RenderTreeBuilder, where we should always attach behind our
beforeChild if we're inserting an inline and beforeChild is an inline,
regardless of other continuation state.
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::RenderTreeBuilder::Inline::insertChildToContinuation):
*
LayoutTests/fast/inline/continuation-inlines-inserted-in-reverse-after-block.html:
Add Test Case
*
LayoutTests/fast/inline/continuation-inlines-inserted-in-reverse-after-block-expected.txt:
Add Test Case Expectation
* LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-3-expected.txt:
Rebaselined
* LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-3-expected.png: Ditto
* LayoutTests/platform/glib/tables/mozilla/bugs/bug113235-3-expected.txt: Ditto
* LayoutTests/platform/ios/tables/mozilla/bugs/bug113235-3-expected.txt: Ditto
Canonical link: https://commits.webkit.org/279422@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
