Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7fc80cb809a3f25a0b6733253a3763dd85e901d8
https://github.com/WebKit/WebKit/commit/7fc80cb809a3f25a0b6733253a3763dd85e901d8
Author: Simon Fraser <[email protected]>
Date: 2024-05-31 (Fri, 31 May 2024)
Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
[UnifiedPDF] Store Find rects in terms of PDFPageCoverage
https://bugs.webkit.org/show_bug.cgi?id=275004
rdar://129086490
Reviewed by Sammy Gill.
Find results are a list of pageIndex/rect pairs, which is exactly what
PDFPageCoverage stores. Storing find results in page coordinates, and only
converting
to plugin coordinates to return from `rectsForTextMatchesInRect()` paves the way
for the future non-scrolling mode.
Drive-by update to `handlePDFActionForAnnotation()` to use
`PDFDocumentLayout::PageIndex`
instead of `unsigned`.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::findString):
(WebKit::UnifiedPDFPlugin::collectFindMatchRects):
(WebKit::UnifiedPDFPlugin::rectsForTextMatchesInRect const):
(WebKit::UnifiedPDFPlugin::handlePDFActionForAnnotation):
Canonical link: https://commits.webkit.org/279607@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
