Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 685f1d6a32833c4313e0cf537addf5451f7372e0
https://github.com/WebKit/WebKit/commit/685f1d6a32833c4313e0cf537addf5451f7372e0
Author: Simon Fraser <[email protected]>
Date: 2024-06-02 (Sun, 02 Jun 2024)
Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
[UnifiedPDF] Migrate from "scroll to" to "reveal" terminology in preparation
for discrete mode
https://bugs.webkit.org/show_bug.cgi?id=275011
rdar://129095225
Reviewed by Abrar Rahman Protyasha.
In discrete (non-scrolling) mode, making some part of the PDF visible is a
"reveal", not
a "scroll", so rename functions accordingly.
It's best to keep things in page-relative coordinates with a PageIndex as long
as possible,
so the most common "reveal" functions are `revealPointInPage()` and
`revealRectInPage()`.
Ultimately these call `scrollToPointInContentsSpace()`.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::installPDFDocument):
(WebKit::UnifiedPDFPlugin::attemptToUnlockPDF):
(WebKit::UnifiedPDFPlugin::didAttachScrollingNode):
(WebKit::UnifiedPDFPlugin::didSameDocumentNavigationForFrame):
(WebKit::UnifiedPDFPlugin::restoreScrollPositionWithInfo):
(WebKit::UnifiedPDFPlugin::followLinkAnnotation):
(WebKit::UnifiedPDFPlugin::revealRectInPage):
(WebKit::UnifiedPDFPlugin::revealPDFDestination):
(WebKit::UnifiedPDFPlugin::revealPointInPage):
(WebKit::UnifiedPDFPlugin::revealPage):
(WebKit::UnifiedPDFPlugin::revealFragmentIfNeeded):
(WebKit::UnifiedPDFPlugin::performContextMenuAction):
(WebKit::UnifiedPDFPlugin::findString):
(WebKit::UnifiedPDFPlugin::accessibilityScrollToPage):
(WebKit::UnifiedPDFPlugin::revealAnnotation):
(WebKit::UnifiedPDFPlugin::handlePDFActionForAnnotation):
(WebKit::UnifiedPDFPlugin::revealRectInContentsSpace): Deleted.
(WebKit::UnifiedPDFPlugin::scrollToPDFDestination): Deleted.
(WebKit::UnifiedPDFPlugin::scrollToPointInPage): Deleted.
(WebKit::UnifiedPDFPlugin::scrollToPage): Deleted.
(WebKit::UnifiedPDFPlugin::scrollToFragmentIfNeeded): Deleted.
Canonical link: https://commits.webkit.org/279623@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
