Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b39622eb0b6b8c1d0b248d189986100521b139e7
https://github.com/WebKit/WebKit/commit/b39622eb0b6b8c1d0b248d189986100521b139e7
Author: David Kilzer <[email protected]>
Date: 2024-06-04 (Tue, 04 Jun 2024)
Changed paths:
M Configurations/CommonBase.xcconfig
M Source/JavaScriptCore/API/tests/testapi.c
M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
M Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp
M Tools/DumpRenderTree/mac/AccessibilityNotificationHandler.mm
M Tools/WebKitTestRunner/InjectedBundle/cocoa/AccessibilityCommonCocoa.mm
M Tools/WebKitTestRunner/ios/HIDEventGenerator.mm
Log Message:
-----------
Enable -Wvla when building WebKit
<https://bugs.webkit.org/show_bug.cgi?id=275081>
<rdar://129190911>
Reviewed by Yusuke Suzuki.
* Configurations/CommonBase.xcconfig:
(WK_COMMON_WARNING_CFLAGS): Add -Wvla.
* Source/JavaScriptCore/API/tests/testapi.c:
(checkJSStringOOBUTF8):
(checkJSStringOOBUTF16):
(checkJSStringOOBUTF16AtEnd):
- Stop using VLAs. Since this is C, we use malloc()/free() instead.
Regressed recently in 279673@main.
* Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
(WK_FIXME_WARNING_CFLAGS): Add -Wno-vla.
- The opus project and one pffft source file use VLAs.
* Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(computeSHA1HashStringForBitmapContext):
- Use a Vector<uint32_t> instead of a VLA.
* Tools/DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
(makeArrayRefForArray):
- Ignore -Wvla warnings for JSValueRef objects that must be allocated on
the stack.
* Tools/WebKitTestRunner/InjectedBundle/cocoa/AccessibilityCommonCocoa.mm:
(WTR::makeJSArray): Ditto.
* Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator touchDown:touchCount:]):
(-[HIDEventGenerator liftUp:touchCount:]):
(-[HIDEventGenerator moveToPoints:touchCount:duration:]):
- Use a Vector<CGPoint> instead of a VLA.
Canonical link: https://commits.webkit.org/279702@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
