Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6a90c24b30807118c2021de2a107b51be8b50da
      
https://github.com/WebKit/WebKit/commit/e6a90c24b30807118c2021de2a107b51be8b50da
  Author: Ross Kirsling <[email protected]>
  Date:   2024-06-04 (Tue, 04 Jun 2024)

  Changed paths:
    M Source/WTF/wtf/HashTable.h

  Log Message:
  -----------
  HashTable should allow alignof(ValueType) to be 32
https://bugs.webkit.org/show_bug.cgi?id=275097

Reviewed by Darin Adler.

HashTable has been assuming that alignof(ValueType) will never exceed 16 (i.e. 
`4 * sizeof(unsigned)`),
but PlayStation is seeing 32 for alignof(std::function<T>), meaning that 
ResourceUsageThread::m_observers
causes us to hit the static_assert in HashTable::allocateTable. We are 
investigating the background of this
alignof value, but regardless, it should still be possible to allocate a 
HashTable under these circumstances.

* Source/WTF/wtf/HashTable.h:
Let metadataSize be larger than `4 * sizeof(unsigned)` when necessary,
so as to preserve the invariant `metadataSize % alignof(ValueType) == 0`.

Canonical link: https://commits.webkit.org/279712@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to