Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c63f556ac82e248edc81bd57bd430e4eb2012d98
https://github.com/WebKit/WebKit/commit/c63f556ac82e248edc81bd57bd430e4eb2012d98
Author: Yoel Hawa <[email protected]>
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
M Source/WebKit/Shared/FullScreenMediaDetails.h
M Source/WebKit/Shared/FullScreenMediaDetails.serialization.in
M Source/WebKit/UIProcess/API/Cocoa/_WKFullscreenDelegate.h
M Source/WebKit/UIProcess/Cocoa/FullscreenClient.h
M Source/WebKit/UIProcess/Cocoa/FullscreenClient.mm
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
M Source/WebKit/UIProcess/ios/PageClientImplIOS.h
M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Log Message:
-----------
[visionOS] Inform the client when Image Fullscreen is delegated to Quick Look
https://bugs.webkit.org/show_bug.cgi?id=273970
<rdar://126655604>
Reviewed by Aditya Keerthi.
Add a new UI delegate method to notify client when image fullscreen has
been delegated to Quick Look, and plumb the image dimensions to this
method.
* Source/WebKit/UIProcess/API/Cocoa/_WKFullscreenDelegate.h:
Add new UI delegate method.
* Source/WebKit/UIProcess/Cocoa/FullscreenClient.h:
* Source/WebKit/UIProcess/Cocoa/FullscreenClient.mm:
(WebKit::FullscreenClient::setDelegate):
(WebKit::FullscreenClient::didEnterFullscreen):
Call new UI delegate method.
* Source/WebKit/Shared/FullScreenMediaDetails.h:
* Source/WebKit/Shared/FullScreenMediaDetails.serialization.in:
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::enterFullScreen):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h:
Generalize name of variable `videoDimensions` to `mediaDimensions`.
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h:
Expose some new public properties.
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController isUsingQuickLook]):
(-[WKFullScreenWindowController imageDimensions]):
(-[WKFullScreenWindowController enterFullScreen:]):
Expose some new public properties, and generalize name of variable
`videoDimensions` to `mediaDimensions`.
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):
Add image dimensions to `mediaDetails` struct iff image fullscreen will
be delegated to Quick Look (to avoid interfering with downstream checks
of existence of dimensions).
Canonical link: https://commits.webkit.org/279728@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
