Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1217711604d0b1da3b6842d58b54f66f43355aa1
      
https://github.com/WebKit/WebKit/commit/1217711604d0b1da3b6842d58b54f66f43355aa1
  Author: Andy Estes <[email protected]>
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources.make
    M 
Source/WebCore/Modules/modern-media-controls/controls/tvos-layout-traits.js
    A 
Source/WebCore/Modules/modern-media-controls/controls/tvos-media-controls.css
    A 
Source/WebCore/Modules/modern-media-controls/controls/tvos-media-controls.js
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  [tvOS] Refine media controls when in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=275166
rdar://129291317

Reviewed by Eric Carlson.

Added TVOSMediaControls to be used when in fullscreen; IOSInlineMediaControls 
is still used for
inline controls. For now, TVOSMediaControls renders a start/stop button and 
10-second back/forward
buttons in a centered controls bar.

Also reverted the change made in 279622@main. While that was necessary to avoid 
showing a start
button when using IOSInlineMediaControls in fullscreen, it resulted in 
TVOSMediaControls never
becoming visible in fullscreen.

* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/modern-media-controls/controls/tvos-layout-traits.js:
(TVOSLayoutTraits.prototype.mediaControlsClass):
* 
Source/WebCore/Modules/modern-media-controls/controls/tvos-media-controls.css: 
Added.
(.media-controls.fullscreen):
(.media-controls.fullscreen.faded):
(.media-controls.fullscreen > .controls-bar.center):
* Source/WebCore/Modules/modern-media-controls/controls/tvos-media-controls.js: 
Added.
(TVOSMediaControls.prototype.layout):
(TVOSMediaControls.prototype._centerContainerButtons):
(TVOSMediaControls):
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::shouldForceControlsDisplay const):

Canonical link: https://commits.webkit.org/279761@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to