Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 132e20aa121367262caab344e193535bef849955
      
https://github.com/WebKit/WebKit/commit/132e20aa121367262caab344e193535bef849955
  Author: Tyler Wilcock <[email protected]>
  Date:   2024-06-06 (Thu, 06 Jun 2024)

  Changed paths:
    M LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
    M LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html
    M Source/JavaScriptCore/inspector/protocol/DOM.json
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    M Source/WebInspectorUI/UserInterface/Models/DOMNode.js
    M Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js

  Log Message:
  -----------
  AX Web Inspector Panel: Switch form controls report "Checked: true/false" 
rather than something like "State: on/off"
https://bugs.webkit.org/show_bug.cgi?id=274846
rdar://128952449

Reviewed by Devin Rousso.

Switches are like checkboxes without a mixed state, and are exposed in the web 
platform in this way — HTML switches
are created via `input type="checkbox"` plus the `switch` attribute, and are 
"enabled" via the `checked` attribute.
And ARIA switches (`role="switch"`) use `aria-checked`.

A side effect of this is that when we added support for switch controls, we 
forgot to update Web Inspector to handle
the nuanced difference between these types of controls, and thus switch 
controls report a "Checked: true/false" state
rather than "State: on/off", which is more appropriate terminology. This patch 
addresses this issue.

* LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
* LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html:
* Source/JavaScriptCore/inspector/protocol/DOM.json:
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Models/DOMNode.js:
(WI.DOMNode.prototype.accessibilityProperties.accessibilityPropertiesCallback):
(WI.DOMNode.prototype.accessibilityProperties):
* Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WI.DOMNodeDetailsSidebarPanel.prototype.initialLayout):
(WI.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
(WI.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):

Canonical link: https://commits.webkit.org/279772@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to