Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6b87830de4887034635dd02fdba85bdf0ebc18a6
https://github.com/WebKit/WebKit/commit/6b87830de4887034635dd02fdba85bdf0ebc18a6
Author: Megan Gardner <[email protected]>
Date: 2024-06-06 (Thu, 06 Jun 2024)
Changed paths:
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
A Source/WebKit/WebProcess/WebPage/Cocoa/TextIndicatorStyleController.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
A Source/WebKit/WebProcess/WebPage/TextIndicatorStyleController.h
M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
Log Message:
-----------
Refactor TextIndicatorStyle to be seperate from
UnifiedTextReplacementController.
https://bugs.webkit.org/show_bug.cgi?id=275169
rdar://129292403
Reviewed by Aditya Keerthi.
TextIndicatorStyle is not always tied to what is happening in
UnifiedTextReplacementController,
so it should be it's own separate system that interacts with
UnifiedTextReplacementController
and WebPage to handle the current styling for all text indicators.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/Cocoa/TextIndicatorStyleController.mm: Added.
(WebKit::TextIndicatorStyleController::TextIndicatorStyleController):
(WebKit::TextIndicatorStyleController::document const):
(WebKit::TextIndicatorStyleController::contextRangeForTextIndicatorStyle const):
(WebKit::TextIndicatorStyleController::cleanUpTextStylesForSessionID):
(WebKit::TextIndicatorStyleController::removeTransparentMarkersForUUID):
(WebKit::newlyReplacedCharacterRange):
(WebKit::TextIndicatorStyleController::addSourceTextIndicatorStyle):
(WebKit::TextIndicatorStyleController::addDestinationTextIndicatorStyle):
(WebKit::TextIndicatorStyleController::updateTextIndicatorStyleVisibilityForID):
(WebKit::TextIndicatorStyleController::createTextIndicatorForRange):
(WebKit::TextIndicatorStyleController::createTextIndicatorForID):
(WebKit::TextIndicatorStyleController::enableTextIndicatorStyleAfterElementWithID):
(WebKit::TextIndicatorStyleController::enableTextIndicatorStyleForElementWithID):
* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange):
(WebKit::UnifiedTextReplacementController::removeTransparentMarkersForUUID):
Deleted.
(WebKit::UnifiedTextReplacementController::removeTransparentMarkersForSession):
Deleted.
(WebKit::UnifiedTextReplacementController::contextRangeForSessionOrRangeWithUUID
const): Deleted.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::createTextIndicatorForID):
(WebKit::WebPage::updateTextIndicatorStyleVisibilityForID):
(WebKit::WebPage::enableTextIndicatorStyleAfterElementWithID):
(WebKit::WebPage::enableTextIndicatorStyleForElementWithID):
(WebKit::WebPage::getRangeForUUID): Deleted.
(WebKit::WebPage::createTextIndicatorForRange): Deleted.
* Source/WebKit/WebProcess/WebPage/TextIndicatorStyleController.h: Added.
* Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textIndicatorStyleController):
(WebKit::m_unifiedTextReplacementController): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::textIndicatorStyleController):
(WebKit::WebPage::unifiedTextReplacementController):
Canonical link: https://commits.webkit.org/279792@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
