Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8a36e70185b493f63385ca48a275a6d29a098c72
https://github.com/WebKit/WebKit/commit/8a36e70185b493f63385ca48a275a6d29a098c72
Author: Etienne Segonzac <[email protected]>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
A LayoutTests/interaction-region/full-page-overlay-page-zoom-expected.txt
A LayoutTests/interaction-region/full-page-overlay-page-zoom.html
M Source/WebCore/page/InteractionRegion.cpp
Log Message:
-----------
Interaction Regions size checks should be independent from page zoom
https://bugs.webkit.org/show_bug.cgi?id=274777
<rdar://128606404>
Reviewed by Simon Fraser.
The input bounds we use to generate Interaction Regions come from the
renderer's paint offset and size (unchanged by scale factor).
In the `isTooBigForInteraction` and `isTooBigForOcclusion` checks, we
compare the region's bounds to the viewport.
Use `baseLayoutViewportSize()` to do so since it's in Document
coordinates (also unchanged by scale factor) and can be safely compared
to the region's bounds.
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
Move the main frame view lookup to where it's actually used.
Remove the (sometimes erroneous) use of `visibleContentScaleFactor`.
* LayoutTests/interaction-region/full-page-overlay-page-zoom-expected.txt:
Added.
* LayoutTests/interaction-region/full-page-overlay-page-zoom.html: Added.
Add a test at high page zoom to cover the change.
Canonical link: https://commits.webkit.org/279820@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
