Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 34e6542dbf34dbd110a8004e24b392b5da665b13
      
https://github.com/WebKit/WebKit/commit/34e6542dbf34dbd110a8004e24b392b5da665b13
  Author: Jinyu Meng <[email protected]>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M Tools/Scripts/webkitdirs.pm

  Log Message:
  -----------
  [Tools] run-webkit-app command not able to set DYLD_FRAMEWORK_PATH under 
SIP-enabled environment.
https://bugs.webkit.org/show_bug.cgi?id=275207

Reviewed by Alexey Proskuryakov.

While using the "run-webkit-app" command to run a demo app with self-built 
WebKit on macOS, the app is still using the system WebKit. The WebKit I built 
is not showing under "Open Files and Ports" in the  "Activity Monitor". You can 
check this thread for more information: 
https://bugs.webkit.org/show_bug.cgi?id=274818

After some hints from Alexey Proskuryakov, I fixed this bug by passing $ENV to 
the "open" command with some "--env" arguments. The "open" command couldn't 
keep environment variables while SIP is enabled.

* Tools/Scripts/webkitdirs.pm:
(commandLineArgumentsForRestrictedEnvironmentVariables):
(runMacWebKitApp):
(archCommandLineArgumentsForRestrictedEnvironmentVariables): Deleted.

[Tools] Remove old code and refactor.
https://bugs.webkit.org/show_bug.cgi?id=275207

Reviewed by Alexey Proskuryakov.

Modified according to the reviewer's suggestion.

* Tools/Scripts/webkitdirs.pm:
(commandLineArgumentsForRestrictedEnvironmentVariables):

Canonical link: https://commits.webkit.org/279822@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to