Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1b56b013aed38c07fe25caae946a50493d748275
https://github.com/WebKit/WebKit/commit/1b56b013aed38c07fe25caae946a50493d748275
Author: Tadeu Zagallo <[email protected]>
Date: 2024-06-10 (Mon, 10 Jun 2024)
Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/ParserPrivate.h
M Source/WebGPU/WGSL/TypeCheck.cpp
A Source/WebGPU/WGSL/tests/invalid/limits-brace-enclosed.wgsl
A Source/WebGPU/WGSL/tests/invalid/limits-composite-type.wgsl
A Source/WebGPU/WGSL/tests/invalid/limits-const-array.wgsl
A Source/WebGPU/WGSL/tests/invalid/limits-function-parameters.wgsl
A Source/WebGPU/WGSL/tests/invalid/limits-function-vars.wgsl
A Source/WebGPU/WGSL/tests/invalid/limits-private-vars.wgsl
A Source/WebGPU/WGSL/tests/invalid/limits-struct-members.wgsl
A Source/WebGPU/WGSL/tests/invalid/limits-switch-case.wgsl
A Source/WebGPU/WGSL/tests/invalid/limits-workgroup-vars.wgsl
R Source/WebGPU/WGSL/tests/invalid/struct-parse.wgsl
M Source/WebGPU/WGSL/tests/valid/type-promotion.wgsl
Log Message:
-----------
[WGSL] All limits should be validated
https://bugs.webkit.org/show_bug.cgi?id=275267
rdar://128923553
Reviewed by Mike Wyrzykowski.
Add validation for all the limits defined in the WGSL spec[1].
[1]: https://www.w3.org/TR/WGSL/#limits
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visit):
(WGSL::RewriteGlobalVariables::visitEntryPoint):
(WGSL::RewriteGlobalVariables::determineUsedGlobals):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseStructure):
(WGSL::Parser<Lexer>::parseTypeName):
(WGSL::Parser<Lexer>::parseFunction):
(WGSL::Parser<Lexer>::parseSwitchStatement):
* Source/WebGPU/WGSL/ParserPrivate.h:
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/limits-brace-enclosed.wgsl: Added.
* Source/WebGPU/WGSL/tests/invalid/limits-composite-type.wgsl: Added.
* Source/WebGPU/WGSL/tests/invalid/limits-const-array.wgsl: Added.
* Source/WebGPU/WGSL/tests/invalid/limits-function-parameters.wgsl: Added.
* Source/WebGPU/WGSL/tests/invalid/limits-function-vars.wgsl: Added.
* Source/WebGPU/WGSL/tests/invalid/limits-private-vars.wgsl: Added.
* Source/WebGPU/WGSL/tests/invalid/limits-struct-members.wgsl: Renamed from
Source/WebGPU/WGSL/tests/invalid/struct-parse.wgsl.
* Source/WebGPU/WGSL/tests/invalid/limits-switch-case.wgsl: Added.
* Source/WebGPU/WGSL/tests/invalid/limits-workgroup-vars.wgsl: Added.
* Source/WebGPU/WGSL/tests/valid/type-promotion.wgsl:
Canonical link: https://commits.webkit.org/279876@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes