Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77ce66bfe1ddb5cb29729707d87b2335ed71fd53
      
https://github.com/WebKit/WebKit/commit/77ce66bfe1ddb5cb29729707d87b2335ed71fd53
  Author: Mike Wyrzykowski <[email protected]>
  Date:   2024-06-10 (Mon, 10 Jun 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_275199-expected.png
    A LayoutTests/fast/webgpu/regression/repro_275199-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275199.html
    A LayoutTests/fast/webgpu/regression/repro_275199b-expected.png
    A LayoutTests/fast/webgpu/regression/repro_275199b-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275199b.html
    M Source/WebGPU/WebGPU/BindGroup.h
    M Source/WebGPU/WebGPU/BindGroup.mm

  Log Message:
  -----------
  [WebGPU] GPUSampler can be garbage collected surprisingly
https://bugs.webkit.org/show_bug.cgi?id=275199
<radar://129272687>

Reviewed by Tadeu Zagallo.

The MTLArgumentBuffer does not retain the MTLSampler here, so we need to 
manually
retain it by holding a RefPtr to it for the lifetime of the BindGroup.

* LayoutTests/fast/webgpu/regression/repro_275199-expected.png: Added.
* LayoutTests/fast/webgpu/regression/repro_275199-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_275199.html: Added.
* LayoutTests/fast/webgpu/regression/repro_275199b-expected.png: Added.
* LayoutTests/fast/webgpu/regression/repro_275199b-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_275199b.html: Added.
* Source/WebGPU/WebGPU/BindGroup.h:
(WebGPU::BindGroup::create):
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
(WebGPU::BindGroup::BindGroup):

Canonical link: https://commits.webkit.org/279883@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to