Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e4bbed49b0933c9ebcb74df0975d37394165bc8b
https://github.com/WebKit/WebKit/commit/e4bbed49b0933c9ebcb74df0975d37394165bc8b
Author: Richard Robinson <[email protected]>
Date: 2024-06-10 (Mon, 10 Jun 2024)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/dom/DocumentMarker.h
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
A
Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementController.h
A
Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementController.mm
A Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementTypes.h
M Source/WebCore/platform/Logging.h
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Platform/Logging.h
M Source/WebKit/Scripts/webkit/messages.py
A Source/WebKit/Shared/TextIndicatorStyle.serialization.in
R Source/WebKit/Shared/UnifiedTextReplacement.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
R Source/WebKit/Shared/WebTextReplacementData.h
R Source/WebKit/Shared/WebUnifiedTextReplacementContextData.h
R Source/WebKit/Shared/WebUnifiedTextReplacementSessionData.h
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/API/APIPageConfiguration.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebPage/Cocoa/TextIndicatorStyleController.mm
R Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/TextIndicatorStyleController.h
R Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Log Message:
-----------
[Unified Text Replacement] Move `UnifiedTextReplacementController` from
WebKit to WebCore
https://bugs.webkit.org/show_bug.cgi?id=275289
rdar://129438122
Reviewed by Aditya Keerthi.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/DocumentMarker.h:
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
(WebCore::ChromeClient::textReplacementSessionUpdateStateForReplacementWithID):
(WebCore::ChromeClient::removeTextIndicatorStyleForID):
(WebCore::ChromeClient::cleanUpTextStylesForSessionID):
(WebCore::ChromeClient::addSourceTextIndicatorStyle):
(WebCore::ChromeClient::addDestinationTextIndicatorStyle):
* Source/WebCore/page/Page.cpp:
(WebCore::m_unifiedTextReplacementController):
(WebCore::Page::willBeginTextReplacementSession):
(WebCore::Page::didBeginTextReplacementSession):
(WebCore::Page::textReplacementSessionDidReceiveReplacements):
(WebCore::Page::textReplacementSessionDidUpdateStateForReplacement):
(WebCore::Page::didEndTextReplacementSession):
(WebCore::Page::textReplacementSessionDidReceiveTextWithReplacementRange):
(WebCore::Page::updateStateForSelectedReplacementIfNeeded):
(WebCore::Page::textReplacementSessionDidReceiveEditAction):
(WebCore::m_historyItemClient): Deleted.
* Source/WebCore/page/Page.h:
(WebCore::Page::unifiedTextReplacementController const):
*
Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementController.h:
Added.
*
Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementController.mm:
Added.
(WebCore::UnifiedTextReplacementController::characterRange):
(WebCore::UnifiedTextReplacementController::characterCount):
(WebCore::UnifiedTextReplacementController::resolveCharacterRange):
(WebCore::UnifiedTextReplacementController::plainText):
(WebCore::UnifiedTextReplacementController::UnifiedTextReplacementController):
(WebCore::contextRangeForDocument):
(WebCore::UnifiedTextReplacementController::willBeginTextReplacementSession):
(WebCore::UnifiedTextReplacementController::didBeginTextReplacementSession):
(WebCore::UnifiedTextReplacementController::textReplacementSessionDidReceiveReplacements):
(WebCore::UnifiedTextReplacementController::textReplacementSessionDidUpdateStateForReplacement):
(WebCore::UnifiedTextReplacementController::didEndTextReplacementSession<UnifiedTextReplacement::Session::ReplacementType::PlainText>):
(WebCore::UnifiedTextReplacementController::didEndTextReplacementSession<UnifiedTextReplacement::Session::ReplacementType::RichText>):
(WebCore::UnifiedTextReplacementController::didEndTextReplacementSession):
(WebCore::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange):
(WebCore::UnifiedTextReplacementController::textReplacementSessionDidReceiveEditAction):
(WebCore::UnifiedTextReplacementController::textReplacementSessionPerformEditActionForPlainText):
(WebCore::UnifiedTextReplacementController::textReplacementSessionPerformEditActionForRichText):
(WebCore::UnifiedTextReplacementController::updateStateForSelectedReplacementIfNeeded):
(WebCore::UnifiedTextReplacementController::contextRangeForSessionWithID const):
(WebCore::UnifiedTextReplacementController::document const):
(WebCore::UnifiedTextReplacementController::findReplacementMarkerByID const):
(WebCore::UnifiedTextReplacementController::findReplacementMarkerContainingRange
const):
(WebCore::UnifiedTextReplacementController::replaceContentsOfRangeInSessionInternal):
(WebCore::UnifiedTextReplacementController::replaceContentsOfRangeInSession):
* Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementTypes.h:
Renamed from Source/WebKit/Shared/WebUnifiedTextReplacementSessionData.h.
* Source/WebCore/platform/Logging.h:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Platform/Logging.h:
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/TextIndicatorStyle.serialization.in: Renamed from
Source/WebKit/Shared/UnifiedTextReplacement.serialization.in.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/Shared/WebTextReplacementData.h: Removed.
* Source/WebKit/Shared/WebUnifiedTextReplacementContextData.h: Removed.
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::unifiedTextReplacementBehavior const):
(API::PageConfiguration::setUnifiedTextReplacementBehavior):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(convertToPlatform):
(convertToWeb):
(-[WKWebViewConfiguration _setUnifiedTextReplacementBehavior:]):
(-[WKWebViewConfiguration _unifiedTextReplacementBehavior]):
(convertToPlatformBehavior): Deleted.
(convertToWebBehavior): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
(WebKit::PageClientImplCocoa::textReplacementSessionUpdateStateForReplacementWithID):
(WebKit::PageClientImplCocoa::textReplacementSessionShowInformationForReplacementWithUUIDRelativeToRect):
Deleted.
(WebKit::PageClientImplCocoa::textReplacementSessionUpdateStateForReplacementWithUUID):
Deleted.
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::willBeginTextReplacementSession):
(WebKit::WebPageProxy::didBeginTextReplacementSession):
(WebKit::WebPageProxy::textReplacementSessionDidReceiveReplacements):
(WebKit::WebPageProxy::textReplacementSessionDidUpdateStateForReplacement):
(WebKit::WebPageProxy::didEndTextReplacementSession):
(WebKit::WebPageProxy::textReplacementSessionDidReceiveTextWithReplacementRange):
(WebKit::WebPageProxy::textReplacementSessionDidReceiveEditAction):
(WebKit::WebPageProxy::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
(WebKit::WebPageProxy::textReplacementSessionUpdateStateForReplacementWithID):
(WebKit::WebPageProxy::textReplacementSessionShowInformationForReplacementWithUUIDRelativeToRect):
Deleted.
(WebKit::WebPageProxy::textReplacementSessionUpdateStateForReplacementWithUUID):
Deleted.
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView unifiedTextReplacementBehavior]):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::unifiedTextReplacementBehavior const):
(WebKit::WebViewImpl::canHandleSwapCharacters const):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
(WebKit::WebChromeClient::textReplacementSessionUpdateStateForReplacementWithID):
(WebKit::WebChromeClient::removeTextIndicatorStyleForID):
(WebKit::WebChromeClient::cleanUpTextStylesForSessionID):
(WebKit::WebChromeClient::addSourceTextIndicatorStyle):
(WebKit::WebChromeClient::addDestinationTextIndicatorStyle):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/TextIndicatorStyleController.mm:
(WebKit::TextIndicatorStyleController::contextRangeForSessionWithID const):
(WebKit::TextIndicatorStyleController::contextRangeForTextIndicatorStyle const):
(WebKit::TextIndicatorStyleController::addSourceTextIndicatorStyle):
(WebKit::TextIndicatorStyleController::addDestinationTextIndicatorStyle):
(WebKit::TextIndicatorStyleController::createTextIndicatorForRange):
* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
Removed.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::updateTextIndicatorStyleVisibilityForID):
(WebKit::WebPage::willBeginTextReplacementSession):
(WebKit::WebPage::didBeginTextReplacementSession):
(WebKit::WebPage::textReplacementSessionDidReceiveReplacements):
(WebKit::WebPage::textReplacementSessionDidUpdateStateForReplacement):
(WebKit::WebPage::didEndTextReplacementSession):
(WebKit::WebPage::textReplacementSessionDidReceiveTextWithReplacementRange):
(WebKit::WebPage::textReplacementSessionDidReceiveEditAction):
(WebKit::WebPage::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
(WebKit::WebPage::textReplacementSessionUpdateStateForReplacementWithID):
(WebKit::WebPage::textReplacementSessionShowInformationForReplacementWithUUIDRelativeToRect):
Deleted.
(WebKit::WebPage::textReplacementSessionUpdateStateForReplacementWithUUID):
Deleted.
* Source/WebKit/WebProcess/WebPage/TextIndicatorStyleController.h:
* Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h: Removed.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeSelection):
(WebKit::WebPage::cleanUpTextStylesForSessionID):
(WebKit::WebPage::addSourceTextIndicatorStyle):
(WebKit::WebPage::addDestinationTextIndicatorStyle):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::textIndicatorStyleController): Deleted.
(WebKit::WebPage::unifiedTextReplacementController): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Canonical link: https://commits.webkit.org/279890@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes