Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0844491bba9b67f0f4c91e642ee3cfcaa2d517d7
      
https://github.com/WebKit/WebKit/commit/0844491bba9b67f0f4c91e642ee3cfcaa2d517d7
  Author: Yusuke Suzuki <[email protected]>
  Date:   2024-06-10 (Mon, 10 Jun 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecode/InlineAccess.cpp
    M Source/JavaScriptCore/bytecode/InlineAccess.h
    M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
    M Source/JavaScriptCore/bytecode/Repatch.cpp
    M Source/JavaScriptCore/bytecode/StructureStubInfo.cpp

  Log Message:
  -----------
  [JSC] Continue using inlined access in DataIC
https://bugs.webkit.org/show_bug.cgi?id=275343
rdar://129547636

Reviewed by Alexey Shvayka.

This patch keeps inlined access even IC starts using Stub path in DataIC. Since 
this inlined access already exists as a code,
we can cotinue using it as a super fast path and it is efficient. But the main 
benefit is that, by doing so, whenever we add a new AccessCase,
we only need to consider about this newly added one AccessCase code generation. 
This is useful for Handler IC's split code since we do not
need to consider generating two codes at one time, one for this already handled 
inlined AccessCase and one for the newly added one.
To make this code work, we simplified InlineAccess code. Now we should just use 
StructureStubInfo::useDataIC bool flag instead of CodeBlock's information,
removing more dependencies to CodeBlock when generating code / setting up code.

* Source/JavaScriptCore/bytecode/InlineAccess.cpp:
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::InlineAccess::canGenerateSelfPropertyReplace):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::isCacheableArrayLength):
(JSC::InlineAccess::generateArrayLength):
(JSC::InlineAccess::isCacheableStringLength):
(JSC::InlineAccess::generateStringLength):
(JSC::InlineAccess::generateSelfInAccess):
* Source/JavaScriptCore/bytecode/InlineAccess.h:
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::succeed):
(JSC::InlineCacheCompiler::calculateLiveRegistersForCallAndExceptionHandling):
(JSC::InlineCacheCompiler::preserveLiveRegistersToStackForCallWithoutExceptions):
(JSC::InlineCacheCompiler::generateAccessCase):
(JSC::InlineCacheCompiler::emitDOMJITGetter):
(JSC::InlineCacheCompiler::emitProxyObjectAccess):
(JSC::InlineCacheCompiler::compile):
* Source/JavaScriptCore/bytecode/Repatch.cpp:
(JSC::repatchSlowPathCall):
(JSC::tryCacheGetBy):
(JSC::tryCachePutBy):
(JSC::tryCacheInBy):
* Source/JavaScriptCore/bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::addAccessCase):
(JSC::StructureStubInfo::reset):
(JSC::StructureStubInfo::rewireStubAsJumpInAccess):
(JSC::StructureStubInfo::resetStubAsJumpInAccess):

Canonical link: https://commits.webkit.org/279895@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to