Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b72b2fab5b3d35823bb71b50f7f0023fccfa7e3c
https://github.com/WebKit/WebKit/commit/b72b2fab5b3d35823bb71b50f7f0023fccfa7e3c
Author: Mike Wyrzykowski <[email protected]>
Date: 2024-06-11 (Tue, 11 Jun 2024)
Changed paths:
A
LayoutTests/fast/webgpu/regression/repro_275276_drawIndexedOOB_BundleEncoder-expected.txt
A
LayoutTests/fast/webgpu/regression/repro_275276_drawIndexedOOB_BundleEncoder.html
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Device.mm
M Source/WebGPU/WebGPU/RenderBundle.h
M Source/WebGPU/WebGPU/RenderBundleEncoder.h
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
Log Message:
-----------
[WebGPU] OOB reads are possible from RenderBundles
https://bugs.webkit.org/show_bug.cgi?id=275276
<radar://129400170>
Reviewed by Dan Glastonbury.
Correct logic in index buffer ICB bounds checking and add regression test.
*
LayoutTests/fast/webgpu/regression/repro_275276_drawIndexedOOB_BundleEncoder-expected.txt:
Added.
*
LayoutTests/fast/webgpu/regression/repro_275276_drawIndexedOOB_BundleEncoder.html:
Added.
Add regression tst.
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
* Source/WebGPU/WebGPU/RenderBundle.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(-[RenderBundleICBWithResources
initWithICB:containerBuffer:pipelineState:depthStencilState:cullMode:frontFace:depthClipMode:depthBias:depthBiasSlopeScale:depthBiasClamp:fragmentDynamicOffsetsBuffer:pipeline:minVertexCounts:]):
(-[RenderBundleICBWithResources minVertexCountForDrawCommand]):
(WebGPU::makeRenderBundleICBWithResources):
(WebGPU::RenderBundleEncoder::endCurrentICB):
(-[RenderBundleICBWithResources
initWithICB:containerBuffer:pipelineState:depthStencilState:cullMode:frontFace:depthClipMode:depthBias:depthBiasSlopeScale:depthBiasClamp:fragmentDynamicOffsetsBuffer:pipeline:]):
Deleted.
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executeBundles):
Canonical link: https://commits.webkit.org/279932@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
