Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a650e644b1ccf02a2aa19f07d5ec4bc706ac8ce
      
https://github.com/WebKit/WebKit/commit/6a650e644b1ccf02a2aa19f07d5ec4bc706ac8ce
  Author: Philippe Normand <[email protected]>
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
    A 
LayoutTests/media/media-source/media-source-video-play-holds-sleep-assertion-expected.txt
    A 
LayoutTests/media/media-source/media-source-video-play-holds-sleep-assertion.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
    M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
    M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h

  Log Message:
  -----------
  [GStreamer][MSE] SleepDisabler not reliably created when playing YouTube 
videos
https://bugs.webkit.org/show_bug.cgi?id=219354

Reviewed by Xabier Rodriguez-Calvar.

When playing videos the display screensaver should be disabled, and when the 
video is paused it
should be re-enabled. This is mostly useful on desktop systems. The sleep 
disabler is handled by
HTMLMediaElement.

Until this patch display sleep wasn't consistently disabled as a result of 
playback request. By
notifying the MediaPlayer of successful GStreamer pipeline state changes the 
HTMLMediaElement gets
another opportunity to update the sleep disabling state. This is done already 
in the
MediaPlayerPrivateGStreamer::updateStates() method, but for some reason the MSE 
player has a
different implementation of that method.

Test: media/media-source/media-source-video-play-holds-sleep-assertion.html

* 
LayoutTests/media/media-source/media-source-video-play-holds-sleep-assertion-expected.txt:
 Added.
* 
LayoutTests/media/media-source/media-source-video-play-holds-sleep-assertion.html:
 Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::progressEventTimerFired):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::pause):
(WebCore::MediaPlayerPrivateGStreamerMSE::checkPlayingConsistency):
(WebCore::MediaPlayerPrivateGStreamerMSE::setShouldDisableSleep):
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):
(WebCore::MediaPlayerPrivateGStreamerMSE::timeIsProgressing const):
* 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

Canonical link: https://commits.webkit.org/279943@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to