Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1465a7975860d39d4b6e1a2f8d2dd4e6a77a3e92
      
https://github.com/WebKit/WebKit/commit/1465a7975860d39d4b6e1a2f8d2dd4e6a77a3e92
  Author: Ahmad Saleem <[email protected]>
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
    M Source/WebCore/svg/SVGAnimationElement.cpp
    M Source/WebCore/svg/SVGAnimationElement.h
    M Source/WebCore/svg/animation/SVGSMILElement.cpp
    M Source/WebCore/svg/animation/SVGSMILElement.h

  Log Message:
  -----------
  Tidy up instance time handling in SVGSMILElement

https://bugs.webkit.org/show_bug.cgi?id=275296

Reviewed by Darin Adler.

Merge: 
https://github.com/chromium/chromium/commit/901d1e45d6a0a49407a7e8936f6edf9b6124c260

Merge the addBeginTime and addEndTime methods into a single method
addInstanceTime (that takes a BeginOrEnd argument.) Migrate callers to
the new method, getting rid of SVGSMILElement::handleConditionEvent in
the process.

Also inline some trivial functions in SVGAnimationElement.

* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::getSimpleDuration const):
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
(WebCore::SVGAnimationElement::beginElement): Deleted.
(WebCore::SVGAnimationElement::endElement): Deleted.
* Source/WebCore/svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::beginElement):
(WebCore::SVGAnimationElement::endElement):
* Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::ConditionEventListener::handleEvent):
(WebCore::SVGSMILElement::addInstanceTime):
(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
(WebCore::SVGSMILElement::removeTimeDependent):
(WebCore::SVGSMILElement::beginByLinkActivation):
(WebCore::SVGSMILElement::addBeginTime): Deleted.
(WebCore::SVGSMILElement::addEndTime): Deleted.
(WebCore::SVGSMILElement::handleConditionEvent): Deleted.
* Source/WebCore/svg/animation/SVGSMILElement.h:

Canonical link: https://commits.webkit.org/279971@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to