Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f72e630473a8785eefb9311e96392874062233a8
      
https://github.com/WebKit/WebKit/commit/f72e630473a8785eefb9311e96392874062233a8
  Author: Andres Gonzalez <[email protected]>
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  -----------
  AX: Clean up construction of TextUnderElementMode and implementation of 
AccessibilityObject::style.
https://bugs.webkit.org/show_bug.cgi?id=275402
<rdar://problem/129683965>

Reviewed by Tyler Wilcock.

Some of the member variables were being initialized with default parameter in a 
constructor while others were initialize with initializers. This patch makes 
the code consistent and more understandable by using initializers for all 
members.
It also straightens out the code of AccessibilityObject::style avoiding 
unnecessary copies.

This is a byproduct of investigation to solve 
https://bugs.webkit.org/show_bug.cgi?id=275059.

* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::textUnderElement):
(WebCore::TextUnderElementMode::TextUnderElementMode): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement const):
(WebCore::AccessibilityNodeObject::title const):
(WebCore::accessibleNameForNode):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::style const):
(WebCore::AccessibilityObject::isAXHidden const):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::textUnderElement):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:

Canonical link: https://commits.webkit.org/279976@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to