Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 89a9ae9c43f42e50267b9924530d22abf920f908
https://github.com/WebKit/WebKit/commit/89a9ae9c43f42e50267b9924530d22abf920f908
Author: Tadeu Zagallo <[email protected]>
Date: 2024-06-13 (Thu, 13 Jun 2024)
Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
A Source/WebGPU/WGSL/tests/valid/array-length-unordered.wgsl
Log Message:
-----------
[WebGPU] error in WGSL::prepare with attached WGSL source
https://bugs.webkit.org/show_bug.cgi?id=275406
rdar://129691678
Reviewed by Mike Wyrzykowski and Dan Glastonbury.
The generated `_ArrayLength` variable's `@binding` was colliding with
user-defined
variables. The issue was that the `@binding` was calculated based in the last
variable in binding group, but the group wasn't sorted, so the last variable
might
not contain the biggest binding for the group.
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::collectGlobals):
* Source/WebGPU/WGSL/tests/valid/array-length-unordered.wgsl: Added.
Canonical link: https://commits.webkit.org/279987@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes