Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8930049ceecd1c421783172cc234a0cbe3eab94d
https://github.com/WebKit/WebKit/commit/8930049ceecd1c421783172cc234a0cbe3eab94d
Author: Yusuke Suzuki <[email protected]>
Date: 2024-06-18 (Tue, 18 Jun 2024)
Changed paths:
M Source/WebCore/css/CSSCustomPropertyValue.cpp
M Source/WebCore/css/CSSCustomPropertyValue.h
Log Message:
-----------
Relax mayDependOnBaseURL condition for custom property
https://bugs.webkit.org/show_bug.cgi?id=275602
rdar://129291831
Reviewed by Antti Koivisto.
Before 275795@main, our caching inline style cache had a bug that it cannot
handle base URL resolution correctly.
It had many bugs for nested CSSValues, missing CSS properties and so on, and
275795@main fixed them.
For CSSCustomPropertyValue, we disabled inline style cache conservatively since
it may include some relative URL
resolution with base URL (previously, we completely ignored and shared the
cache. That was completely wrong.)
But it turned out that our bug caused some caching works, and now they are
disabled because of the fix.
In this patch, we add a bit more precise handling of CSSCustomPropertyValue for
mayDependOnBaseURL information to
expand caching effectiveness.
* Source/WebCore/css/CSSCustomPropertyValue.cpp:
(WebCore::mayDependOnBaseURL):
(WebCore::CSSCustomPropertyValue::customMayDependOnBaseURL const):
* Source/WebCore/css/CSSCustomPropertyValue.h:
Canonical link: https://commits.webkit.org/280125@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
