Title: [111007] trunk/Source/WebCore
Revision
111007
Author
[email protected]
Date
2012-03-16 07:53:01 -0700 (Fri, 16 Mar 2012)

Log Message

MediaStream API (JSEP): Fixing a few nits
https://bugs.webkit.org/show_bug.cgi?id=81322

Reviewed by Adam Barth.

Addressing the nits from bugs 81206 and 81207.

Nothing to test.

* Modules/mediastream/SessionDescription.idl:
* platform/mediastream/IceOptions.h:
(WebCore::IceOptions::IceOptions):
* platform/mediastream/SessionDescriptionDescriptor.h:
(SessionDescriptionDescriptor):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (111006 => 111007)


--- trunk/Source/WebCore/ChangeLog	2012-03-16 14:48:05 UTC (rev 111006)
+++ trunk/Source/WebCore/ChangeLog	2012-03-16 14:53:01 UTC (rev 111007)
@@ -1,3 +1,20 @@
+2012-03-16  Tommy Widenflycht  <[email protected]>
+
+        MediaStream API (JSEP): Fixing a few nits
+        https://bugs.webkit.org/show_bug.cgi?id=81322
+
+        Reviewed by Adam Barth.
+
+        Addressing the nits from bugs 81206 and 81207.
+
+        Nothing to test.
+
+        * Modules/mediastream/SessionDescription.idl:
+        * platform/mediastream/IceOptions.h:
+        (WebCore::IceOptions::IceOptions):
+        * platform/mediastream/SessionDescriptionDescriptor.h:
+        (SessionDescriptionDescriptor):
+
 2012-03-16  Peter Rybin  <[email protected]>
 
         Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters

Modified: trunk/Source/WebCore/Modules/mediastream/SessionDescription.idl (111006 => 111007)


--- trunk/Source/WebCore/Modules/mediastream/SessionDescription.idl	2012-03-16 14:48:05 UTC (rev 111006)
+++ trunk/Source/WebCore/Modules/mediastream/SessionDescription.idl	2012-03-16 14:53:01 UTC (rev 111007)
@@ -34,10 +34,8 @@
         Conditional=MEDIA_STREAM,
         Constructor(in DOMString sdp)
     ] SessionDescription {
-        // adds the specified candidate to the description
         void addCandidate(in IceCandidate candidate);
 
-        // serializes the description to SDP
         DOMString toSdp();
     };
 

Modified: trunk/Source/WebCore/platform/mediastream/IceOptions.h (111006 => 111007)


--- trunk/Source/WebCore/platform/mediastream/IceOptions.h	2012-03-16 14:48:05 UTC (rev 111006)
+++ trunk/Source/WebCore/platform/mediastream/IceOptions.h	2012-03-16 14:53:01 UTC (rev 111007)
@@ -52,7 +52,7 @@
     UseCandidatesOption useCandidates() { return m_useCandidates; }
 
  private:
-    IceOptions(UseCandidatesOption useCandidates) : m_useCandidates(useCandidates) { }
+    explicit IceOptions(UseCandidatesOption useCandidates) : m_useCandidates(useCandidates) { }
 
     UseCandidatesOption m_useCandidates;
 };

Modified: trunk/Source/WebCore/platform/mediastream/SessionDescriptionDescriptor.h (111006 => 111007)


--- trunk/Source/WebCore/platform/mediastream/SessionDescriptionDescriptor.h	2012-03-16 14:48:05 UTC (rev 111006)
+++ trunk/Source/WebCore/platform/mediastream/SessionDescriptionDescriptor.h	2012-03-16 14:53:01 UTC (rev 111007)
@@ -54,7 +54,7 @@
     const String& initialSdp();
 
 private:
-    SessionDescriptionDescriptor(const String& sdp);
+    explicit SessionDescriptionDescriptor(const String& sdp);
 
     String m_initialSdp;
     Vector<RefPtr<IceCandidateDescriptor> > m_candidates;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to