Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 88e0d4623c8d3afce5dd71538244a7e2c1fe1cf8
https://github.com/WebKit/WebKit/commit/88e0d4623c8d3afce5dd71538244a7e2c1fe1cf8
Author: Richard Robinson <[email protected]>
Date: 2024-06-20 (Thu, 20 Jun 2024)
Changed paths:
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/page/ContextMenuClient.h
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/writing-tools/WritingToolsController.h
M Source/WebCore/page/writing-tools/WritingToolsController.mm
M Source/WebCore/platform/ContextMenuItem.cpp
M Source/WebCore/platform/ContextMenuItem.h
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebCore/platform/Logging.h
M Source/WebKit/Shared/API/c/WKContextMenuItemTypes.h
M Source/WebKit/Shared/API/c/WKSharedAPICast.h
M Source/WebKit/UIProcess/API/APIPageConfiguration.h
M Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm
M Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.mm
M Source/WebKit/UIProcess/mac/PageClientImplMac.h
M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
M Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm
Log Message:
-----------
[Writing Tools] Rename Writing Tools methods
https://bugs.webkit.org/show_bug.cgi?id=275670
rdar://130162952
Reviewed by Abrar Rahman Protyasha.
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/loader/EmptyClients.cpp:
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebCore::ChromeClient::proofreadingSessionUpdateStateForSuggestionWithID):
(WebCore::ChromeClient::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
Deleted.
(WebCore::ChromeClient::textReplacementSessionUpdateStateForReplacementWithID):
Deleted.
* Source/WebCore/page/ContextMenuClient.h:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::willBeginWritingToolsSession):
(WebCore::Page::didBeginWritingToolsSession):
(WebCore::Page::proofreadingSessionDidReceiveSuggestions):
(WebCore::Page::proofreadingSessionDidUpdateStateForSuggestion):
(WebCore::Page::didEndWritingToolsSession):
(WebCore::Page::compositionSessionDidReceiveTextWithReplacementRange):
(WebCore::Page::updateStateForSelectedSuggestionIfNeeded):
(WebCore::Page::writingToolsSessionDidReceiveAction):
(WebCore::Page::willBeginTextReplacementSession): Deleted.
(WebCore::Page::didBeginTextReplacementSession): Deleted.
(WebCore::Page::textReplacementSessionDidReceiveReplacements): Deleted.
(WebCore::Page::textReplacementSessionDidUpdateStateForReplacement): Deleted.
(WebCore::Page::didEndTextReplacementSession): Deleted.
(WebCore::Page::textReplacementSessionDidReceiveTextWithReplacementRange):
Deleted.
(WebCore::Page::updateStateForSelectedReplacementIfNeeded): Deleted.
(WebCore::Page::textReplacementSessionDidReceiveEditAction): Deleted.
* Source/WebCore/page/Page.h:
* Source/WebCore/page/writing-tools/WritingToolsController.h:
* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::willBeginWritingToolsSession):
(WebCore::WritingToolsController::didBeginWritingToolsSession):
(WebCore::WritingToolsController::proofreadingSessionDidReceiveSuggestions):
(WebCore::WritingToolsController::proofreadingSessionDidUpdateStateForSuggestion):
(WebCore::WritingToolsController::compositionSessionDidReceiveTextWithReplacementRange):
(WebCore::WritingToolsController::writingToolsSessionDidReceiveAction<WritingTools::Session::Type::Proofreading>):
(WebCore::WritingToolsController::writingToolsSessionDidReceiveAction<WritingTools::Session::Type::Composition>):
(WebCore::WritingToolsController::writingToolsSessionDidReceiveAction):
(WebCore::WritingToolsController::didEndWritingToolsSession<WritingTools::Session::Type::Proofreading>):
(WebCore::WritingToolsController::didEndWritingToolsSession<WritingTools::Session::Type::Composition>):
(WebCore::WritingToolsController::didEndWritingToolsSession):
(WebCore::WritingToolsController::updateStateForSelectedSuggestionIfNeeded):
(WebCore::WritingToolsController::willBeginTextReplacementSession): Deleted.
(WebCore::WritingToolsController::didBeginTextReplacementSession): Deleted.
(WebCore::WritingToolsController::textReplacementSessionDidReceiveReplacements):
Deleted.
(WebCore::WritingToolsController::textReplacementSessionDidUpdateStateForReplacement):
Deleted.
(WebCore::WritingToolsController::textReplacementSessionDidReceiveTextWithReplacementRange):
Deleted.
(WebCore::WritingToolsController::textReplacementSessionDidReceiveEditAction<WritingTools::Session::Type::Proofreading>):
Deleted.
(WebCore::WritingToolsController::textReplacementSessionDidReceiveEditAction<WritingTools::Session::Type::Composition>):
Deleted.
(WebCore::WritingToolsController::textReplacementSessionDidReceiveEditAction):
Deleted.
(WebCore::WritingToolsController::didEndTextReplacementSession<WritingTools::Session::Type::Proofreading>):
Deleted.
(WebCore::WritingToolsController::didEndTextReplacementSession<WritingTools::Session::Type::Composition>):
Deleted.
(WebCore::WritingToolsController::didEndTextReplacementSession): Deleted.
(WebCore::WritingToolsController::updateStateForSelectedReplacementIfNeeded):
Deleted.
* Source/WebCore/platform/ContextMenuItem.cpp:
(WebCore::isValidContextMenuAction):
* Source/WebCore/platform/ContextMenuItem.h:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagWritingTools):
(WebCore::contextMenuItemTagSwapCharacters): Deleted.
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebCore/platform/Logging.h:
* Source/WebKit/Shared/API/c/WKContextMenuItemTypes.h:
* Source/WebKit/Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::writingToolsBehavior const):
(API::PageConfiguration::setWritingToolsBehavior):
(API::PageConfiguration::unifiedTextReplacementBehavior const): Deleted.
(API::PageConfiguration::setUnifiedTextReplacementBehavior): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
* Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView isWritingToolsActive]):
(-[WKWebView willBeginWritingToolsSession:requestContexts:]):
(-[WKWebView didBeginWritingToolsSession:contexts:]):
(-[WKWebView
proofreadingSession:didReceiveSuggestions:processedRange:inContext:finished:]):
(-[WKWebView
proofreadingSession:didUpdateState:forSuggestionWithUUID:inContext:]):
(-[WKWebView didEndWritingToolsSession:accepted:]):
(-[WKWebView
compositionSession:didReceiveText:replacementRange:inContext:finished:]):
(-[WKWebView writingToolsSession:didReceiveAction:]):
(-[WKWebView
_proofreadingSessionWithUUID:showDetailsForSuggestionWithUUID:relativeToRect:]):
(-[WKWebView _proofreadingSessionWithUUID:updateState:forSuggestionWithUUID:]):
(-[WKWebView
_textReplacementSession:showInformationForReplacementWithUUID:relativeToRect:]):
Deleted.
(-[WKWebView _textReplacementSession:updateState:forReplacementWithUUID:]):
Deleted.
(-[WKWebView _isUnifiedTextReplacementActive]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration setWritingToolsBehavior:]):
(-[WKWebViewConfiguration writingToolsBehavior]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView _web_wantsWritingToolsInlineEditing]):
(-[WKWebView _web_wantsCompleteUnifiedTextReplacementBehavior]): Deleted.
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebKit::PageClientImplCocoa::proofreadingSessionUpdateStateForSuggestionWithID):
(WebKit::PageClientImplCocoa::writingToolsActiveWillChange):
(WebKit::PageClientImplCocoa::writingToolsActiveDidChange):
(WebKit::PageClientImplCocoa::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
Deleted.
(WebKit::PageClientImplCocoa::textReplacementSessionUpdateStateForReplacementWithID):
Deleted.
(WebKit::PageClientImplCocoa::unifiedTextReplacementActiveWillChange): Deleted.
(WebKit::PageClientImplCocoa::unifiedTextReplacementActiveDidChange): Deleted.
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::canHandleContextMenuWritingTools const):
(WebKit::WebPageProxy::handleContextMenuWritingTools):
(WebKit::WebPageProxy::setWritingToolsActive):
(WebKit::WebPageProxy::willBeginWritingToolsSession):
(WebKit::WebPageProxy::didBeginWritingToolsSession):
(WebKit::WebPageProxy::proofreadingSessionDidReceiveSuggestions):
(WebKit::WebPageProxy::proofreadingSessionDidUpdateStateForSuggestion):
(WebKit::WebPageProxy::didEndWritingToolsSession):
(WebKit::WebPageProxy::compositionSessionDidReceiveTextWithReplacementRange):
(WebKit::WebPageProxy::writingToolsSessionDidReceiveAction):
(WebKit::WebPageProxy::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebKit::WebPageProxy::proofreadingSessionUpdateStateForSuggestionWithID):
(WebKit::WebPageProxy::canHandleSwapCharacters const): Deleted.
(WebKit::WebPageProxy::handleContextMenuSwapCharacters): Deleted.
(WebKit::WebPageProxy::setUnifiedTextReplacementActive): Deleted.
(WebKit::WebPageProxy::willBeginTextReplacementSession): Deleted.
(WebKit::WebPageProxy::didBeginTextReplacementSession): Deleted.
(WebKit::WebPageProxy::textReplacementSessionDidReceiveReplacements): Deleted.
(WebKit::WebPageProxy::textReplacementSessionDidUpdateStateForReplacement):
Deleted.
(WebKit::WebPageProxy::didEndTextReplacementSession): Deleted.
(WebKit::WebPageProxy::textReplacementSessionDidReceiveTextWithReplacementRange):
Deleted.
(WebKit::WebPageProxy::textReplacementSessionDidReceiveEditAction): Deleted.
(WebKit::WebPageProxy::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
Deleted.
(WebKit::WebPageProxy::textReplacementSessionUpdateStateForReplacementWithID):
Deleted.
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _updateTextInputTraits:]):
(-[WKContentView unifiedTextReplacementBehavior]): Deleted.
(-[WKContentView _updateTextInputTraitsForUnifiedTextReplacement:]): Deleted.
* Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.mm:
(-[WKExtendedTextInputTraits restoreDefaultValues]):
(-[WKExtendedTextInputTraits restoreDefaultWritingToolsBehaviorValue]):
(-[WKExtendedTextInputTraits
restoreDefaultUnifiedTextReplacementBehaviorValue]): Deleted.
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::canHandleContextMenuWritingTools const):
(WebKit::PageClientImpl::handleContextMenuWritingTools):
(WebKit::PageClientImpl::canHandleSwapCharacters const): Deleted.
(WebKit::PageClientImpl::handleContextMenuSwapCharacters): Deleted.
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::selectionDidChange):
(WebKit::WebViewImpl::canHandleContextMenuWritingTools const):
(WebKit::WebViewImpl::handleContextMenuWritingTools):
(WebKit::WebViewImpl::unifiedTextReplacementBehavior const): Deleted.
(WebKit::WebViewImpl::wantsCompleteUnifiedTextReplacementBehavior const):
Deleted.
(WebKit::WebViewImpl::canHandleSwapCharacters const): Deleted.
(WebKit::WebViewImpl::handleContextMenuSwapCharacters): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebKit::WebChromeClient::proofreadingSessionUpdateStateForSuggestionWithID):
(WebKit::WebChromeClient::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
Deleted.
(WebKit::WebChromeClient::textReplacementSessionUpdateStateForReplacementWithID):
Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::handleWritingTools):
(WebKit::WebContextMenuClient::handleSwapCharacters): Deleted.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::willBeginWritingToolsSession):
(WebKit::WebPage::didBeginWritingToolsSession):
(WebKit::WebPage::proofreadingSessionDidReceiveSuggestions):
(WebKit::WebPage::proofreadingSessionDidUpdateStateForSuggestion):
(WebKit::WebPage::didEndWritingToolsSession):
(WebKit::WebPage::compositionSessionDidReceiveTextWithReplacementRange):
(WebKit::WebPage::writingToolsSessionDidReceiveAction):
(WebKit::WebPage::proofreadingSessionShowDetailsForSuggestionWithIDRelativeToRect):
(WebKit::WebPage::proofreadingSessionUpdateStateForSuggestionWithID):
(WebKit::WebPage::willBeginTextReplacementSession): Deleted.
(WebKit::WebPage::didBeginTextReplacementSession): Deleted.
(WebKit::WebPage::textReplacementSessionDidReceiveReplacements): Deleted.
(WebKit::WebPage::textReplacementSessionDidUpdateStateForReplacement): Deleted.
(WebKit::WebPage::didEndTextReplacementSession): Deleted.
(WebKit::WebPage::textReplacementSessionDidReceiveTextWithReplacementRange):
Deleted.
(WebKit::WebPage::textReplacementSessionDidReceiveEditAction): Deleted.
(WebKit::WebPage::textReplacementSessionShowInformationForReplacementWithIDRelativeToRect):
Deleted.
(WebKit::WebPage::textReplacementSessionUpdateStateForReplacementWithID):
Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeSelection):
(WebKit::WebPage::handleContextMenuWritingTools):
(WebKit::WebPage::handleContextMenuSwapCharacters): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::handleWritingTools):
(WebContextMenuClient::handleSwapCharacters): Deleted.
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(toAction):
(toTag):
* Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, APIWithBehaviorNone)):
(TEST(WritingTools, APIWithBehaviorDefault)):
(TEST(WritingTools, APIWithBehaviorComplete)):
Canonical link: https://commits.webkit.org/280205@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
