Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: af82d039befef621d3c29eac32a787a727a5deb4
https://github.com/WebKit/WebKit/commit/af82d039befef621d3c29eac32a787a727a5deb4
Author: Alex Christensen <[email protected]>
Date: 2024-06-20 (Thu, 20 Jun 2024)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
Log Message:
-----------
Effectively revert 278995@main
https://bugs.webkit.org/show_bug.cgi?id=275708
rdar://129130217
Reviewed by Abrar Rahman Protyasha.
In 278995@main I introduced a cool new model of writing asynchronous code and
started using it
for WebPageProxy::decidePolicyForNavigationAction. However, when callCoroutine
is called, the
call frame of its lambda is leaked because the return value of the
Function<Task()> is discarded.
This caused a 64 byte memory leak every time a frame is navigated.
Straightforward changes introduce memory management issues, so until I figure
out what to do,
let's just make the code do what it used to without coroutines for the lowest
risk change.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::awaitableDecidePolicyForNavigationAction): Deleted.
(WebKit::WebPageProxy::continueDecidePolicyForNavigationAction): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
Canonical link: https://commits.webkit.org/280228@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
