Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e127c6bb3b51fa1c5b2448c44f64d512f3aa7cd0
https://github.com/WebKit/WebKit/commit/e127c6bb3b51fa1c5b2448c44f64d512f3aa7cd0
Author: Chris Dumez <[email protected]>
Date: 2024-06-21 (Fri, 21 Jun 2024)
Changed paths:
M Source/WebKit/UIProcess/WebBackForwardCache.cpp
M Source/WebKit/UIProcess/WebBackForwardCache.h
Log Message:
-----------
Make WebBackForwardCache's m_itemsWithCachedPage more robust
https://bugs.webkit.org/show_bug.cgi?id=275744
rdar://129706255
Reviewed by Alex Christensen.
Use a WeakListHashSet instead of a Vector<WeakPtr<>> for m_itemsWithCachedPage.
This is less error-prone as it will avoid crashes if a WebBackForwardList item
gets destroyed without unregistering itself from the WebBackForwardListCache
first.
This should avoid crashes such as in rdar://129706255.
* Source/WebKit/UIProcess/WebBackForwardCache.cpp:
(WebKit::WebBackForwardCache::addEntry):
(WebKit::WebBackForwardCache::removeEntry):
(WebKit::WebBackForwardCache::takeSuspendedPage):
(WebKit::WebBackForwardCache::removeEntriesMatching):
(WebKit::WebBackForwardCache::clear):
* Source/WebKit/UIProcess/WebBackForwardCache.h:
Canonical link: https://commits.webkit.org/280264@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
