Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a33bb8bc70a1b75e1e45a0a85fb299e62a45005c
https://github.com/WebKit/WebKit/commit/a33bb8bc70a1b75e1e45a0a85fb299e62a45005c
Author: Sam Weinig <[email protected]>
Date: 2024-06-22 (Sat, 22 Jun 2024)
Changed paths:
M LayoutTests/fast/gradients/css3-gradient-parsing-expected.txt
M LayoutTests/fast/gradients/css3-gradient-parsing.html
M LayoutTests/fast/gradients/unprefixed-gradient-parsing-expected.txt
M LayoutTests/fast/gradients/unprefixed-gradient-parsing.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/gradient-interpolation-method-computed.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-image-computed.sub-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-linear-radial-conic-gradient-001-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-image-computed.sub-expected.txt
M Source/WTF/wtf/MathExtras.h
M Source/WebCore/css/CSSGradientValue.cpp
M Source/WebCore/css/CSSGradientValue.h
M Source/WebCore/css/CSSPrimitiveValue.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+UnevaluatedCalc.h
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/rendering/style/StyleGradientImage.cpp
M Source/WebCore/rendering/style/StyleGradientImage.h
Log Message:
-----------
Resolve remaining parts of CSS gradient specifiers to Lengths at style
builder time
https://bugs.webkit.org/show_bug.cgi?id=275667
Reviewed by Darin Adler.
Updates style gradient representations to stop using CSSValues and instead
have Lengths (or other raw values) computed at style builder time.
Additionally, a few uses of CSSValues in the CSS gradient representation
were replaced with more direct values (Raw/UnevaluatedCalc) where we have
good support (that is, all the non-<length-percentage> places). Once there
is additional work for supporting <length-percentage>, further strong typing
can be added.
* LayoutTests/fast/gradients/css3-gradient-parsing-expected.txt:
* LayoutTests/fast/gradients/css3-gradient-parsing.html:
* LayoutTests/fast/gradients/unprefixed-gradient-parsing-expected.txt:
* LayoutTests/fast/gradients/unprefixed-gradient-parsing.html:
- Update tests and results to account for proper computed value
serialization of positions.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/gradient-interpolation-method-computed.html:
- Update test to latest in WPT, which we now pass again.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-image-computed.sub-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-linear-radial-conic-gradient-001-expected.txt:
- Update results for now passing test.
* Source/WTF/wtf/MathExtras.h:
- Add additional radian conversions and remove unnecessary "inline"
specifiers.
* Source/WebCore/css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::computeRadians):
- Add helper akin to computeDegrees to directly compute radians.
* Source/WebCore/css/CSSGradientValue.cpp:
* Source/WebCore/css/CSSGradientValue.h:
- Update to use more strongly typed representations and to process
values into lengths at style builder time.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+UnevaluatedCalc.h:
(WebCore::evaluateCalc):
- Move generic catchall above other uses so it can always be found.
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
- Update consumers to produce new CSS representation.
* Source/WebCore/rendering/style/StyleGradientImage.cpp:
* Source/WebCore/rendering/style/StyleGradientImage.h:
- Update specifiers to have computed Length values, removing
most reliance on CSS gradient types (except enums).
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::autoFillStrongPasswordMaskImage):
- Update to use Lengths.
Canonical link: https://commits.webkit.org/280278@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
