Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6cd42b4fb7cb80ad3e91feecc3e6a49390ed74e
      
https://github.com/WebKit/WebKit/commit/b6cd42b4fb7cb80ad3e91feecc3e6a49390ed74e
  Author: Charlie Wolfe <[email protected]>
  Date:   2024-06-25 (Tue, 25 Jun 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  Replace key and mouse event completion handlers with `DidReceiveEvent`
https://bugs.webkit.org/show_bug.cgi?id=275831
rdar://130157628

Reviewed by Alex Christensen.

This change effectively reverts 267849@main and each of its followup fixes 
(269366@main, 278568@main,
279333@main). It was initially done as part of implementing key and mouse 
events with site isolation, but
it has caused several rare and difficult to diagnose bugs where the completion 
handler returned on web
process termination would cause event queues to have an outstanding event 
reply. Using an explicit IPC
message to dequeue events allows us to clear the event queues on web process 
termination and forget about
the events that have not yet sent a reply.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendMouseEvent):
(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::sendKeyEvent):
(WebKit::WebPageProxy::sendGestureEvent):
(WebKit::WebPageProxy::mouseEventHandlingCompleted):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::handleMouseEventReply): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::sendDidReceiveEvent):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::flushDeferredDidReceiveMouseEvent):
(WebKit::WebPage::keyEvent):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/280344@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to