Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2bc6c250ae104d10775fe6240906378d997313c0
https://github.com/WebKit/WebKit/commit/2bc6c250ae104d10775fe6240906378d997313c0
Author: Per Arne Vollan <[email protected]>
Date: 2024-06-26 (Wed, 26 Jun 2024)
Changed paths:
M Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
M Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements
M Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig
M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
Log Message:
-----------
Local WebKit builds don't use locally-built WebKit process extensions
https://bugs.webkit.org/show_bug.cgi?id=273550
rdar://125726458
Reviewed by Elliott Williams.
When locally built WebKit extensions are installed in the app bundle, these
extensions
will be launched instead of the system extensions when launching said app. This
patch
adds a build step that copies extensions to WebKitTestRunner app bundle.
When WebKitTestRunner contains browser extensions, it also needs the Web browser
entitlement. Adding this introduced a couple of test failures related to in-app
browsers. These failures were resolved by adding a bundle ID check for the
custom
bundle ID that is set in these tests.
* Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.h:
* Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:
(WebKit::treatAsNonBrowser):
(WebKit::isParentProcessAFullWebBrowser):
(WebKit::isFullWebBrowserOrRunningTest):
(WebKit::isInWebKitChildProcess):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::hasExtensionInAppBundle):
(WebKit::launchWithExtensionKit):
* Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
* Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/280387@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
