Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7efed1057bbde6544e4e2efa630e773a2a7a5c50
https://github.com/WebKit/WebKit/commit/7efed1057bbde6544e4e2efa630e773a2a7a5c50
Author: Ben Nham <[email protected]>
Date: 2024-07-02 (Tue, 02 Jul 2024)
Changed paths:
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp
M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp
M Source/WebKit/webpushd/PushClientConnection.h
M Source/WebKit/webpushd/PushClientConnection.messages.in
M Source/WebKit/webpushd/PushClientConnection.mm
M Source/WebKit/webpushd/WebPushDaemon.h
M Source/WebKit/webpushd/WebPushDaemon.mm
Log Message:
-----------
Remove deletePushAndNotificationRegistration IPC from webpushd
https://bugs.webkit.org/show_bug.cgi?id=276137
rdar://130989383
Reviewed by Brady Eidson.
The deletePushAndNotificationRegistration IPC does almost exactly the same
thing as the
removePushSubscriptionsForOrigin IPC. The only difference is that the former
IPC does some extra
validation of the bundle ID in WebPushDaemon, but this is unnecessary since we
later validate the
bundle ID in PushService. This removes deletePushAndNotificationRegistration
and uses
removePushSubscriptionsForOrigin in its place.
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::removePushSubscriptionsForOrigin):
(WebKit::NetworkProcess::deletePushAndNotificationRegistration): Deleted.
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::deletePushAndNotificationRegistration):
Deleted.
* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::removePushSubscriptionsForOrigin):
(WebKit::NetworkProcessProxy::deletePushAndNotificationRegistration): Deleted.
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::removePushSubscriptionsForOrigins):
* Source/WebKit/webpushd/PushClientConnection.h:
* Source/WebKit/webpushd/PushClientConnection.messages.in:
* Source/WebKit/webpushd/PushClientConnection.mm:
(WebPushD::PushClientConnection::deletePushAndNotificationRegistration):
Deleted.
* Source/WebKit/webpushd/WebPushDaemon.h:
* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::WebPushDaemon::setPushAndNotificationsEnabledForOrigin):
(WebPushD::WebPushDaemon::deletePushRegistration): Deleted.
(WebPushD::WebPushDaemon::deletePushAndNotificationRegistration): Deleted.
(WebPushD::WebPushDaemon::canRegisterForNotifications): Deleted.
Canonical link: https://commits.webkit.org/280609@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
