Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e08a72c3d292c1ef4fd66f9c2efb96581ec7ca87
https://github.com/WebKit/WebKit/commit/e08a72c3d292c1ef4fd66f9c2efb96581ec7ca87
Author: Rob Buis <[email protected]>
Date: 2024-07-03 (Wed, 03 Jul 2024)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-204-205-download-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-file-url-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-pagehide-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-pagehide-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-pagehide-unserializablestate-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-double-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-event-order-expected.txt
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/page/Navigation.cpp
Log Message:
-----------
[Navigation] Detect early error in Navigation.navigate
https://bugs.webkit.org/show_bug.cgi?id=276129
Reviewed by Alex Christensen.
Detect early error in Navigation.navigate for the case the navigate event was
not dispatched [1].
This PR also removes the code for dispatching navigate events in
FrameLoader::loadWithDocumentLoader, because
since r280526 this is handled by FrameLoader::loadURL, and in fact we could end
up with multiple navigate
events being dispatched.
[1]
https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-navigate
(Step 12.2)
*
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-204-205-download-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-file-url-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-pagehide-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-pagehide-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-pagehide-unserializablestate-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-double-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-event-order-expected.txt:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::navigate):
Canonical link: https://commits.webkit.org/280616@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
