Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 85d92cb302530d37a2393be1f116e7a5db924c70
https://github.com/WebKit/WebKit/commit/85d92cb302530d37a2393be1f116e7a5db924c70
Author: Aditya Keerthi <[email protected]>
Date: 2024-07-03 (Wed, 03 Jul 2024)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm
Log Message:
-----------
REGRESSION (280518@main): [ios-simulator] WritingTools API behavior tests are
constant failures
https://bugs.webkit.org/show_bug.cgi?id=276177
rdar://131059140
Reviewed by Richard Robinson.
Following 280518@main `writingToolsBehavior` is implemented on
`WKContentViewInteraction` / `WKWebView` on iOS and macOS respectively.
This is necessary to ensure the system honors the trait.
The change also means that `UITextInputTraits` object itself no longer
implements `writingToolsBehavior`, as it is unnecessary. However, tests
were still asserting things on the object, resulting in a crash.
Simply remove the expectations as they are incorrect. There are already
existing expectations which ensure the same test coverage higher up in
the 3 tests.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, APIWithBehaviorComplete)):
(TEST(WritingTools, APIWithBehaviorDefault)):
(TEST(WritingTools, APIWithBehaviorNone)):
Canonical link: https://commits.webkit.org/280626@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
