Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9a083c67ec38fa2f7e72bf42745b083b5b7db207
https://github.com/WebKit/WebKit/commit/9a083c67ec38fa2f7e72bf42745b083b5b7db207
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2024-07-04 (Thu, 04 Jul 2024)
Changed paths:
M Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py
M Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
A
Tools/Scripts/webkitpy/benchmark_runner/data/patches/extra/MotionMark1.3-15FPS.patch
A
Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.3-15fps.plan
M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
Log Message:
-----------
[run-benchmark] Add motionmark1.3 plan variant that enforces 15fps for
low-end devices
https://bugs.webkit.org/show_bug.cgi?id=276127
Reviewed by Nikolas Zimmermann.
With the default MotionMark settings on low-end devices like the RPi4 the
results
are so low (1-3 pts) that it is impossible to use this benchmark to performance
regression tracking.
This adds a variant of motionmark-1.3 with a target frame-rate of 15FPS, that
way on the RPi4 boards we can get scores around 100-600 which are much more
useful
to track performance regressions.
We tested with 30FPS but that is still too much for this boards with MotionMark.
The animations on the screen also look better, you can clear see more complexity
in the animations even when you can see that that it animates with low FPS.
In order to avoid copying-pasting the whole plan itself this patch also
introduces
a way of importing another plan inside a run-benchmark .plan file via the key
`import_plan_file` and also allows to apply an extra patch via the key
`extra_patch`
that will be applied at the end of the patch process.
That allows to see more clearly what this plan changes on top of the default
MotionMark
plan.
* Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder.__enter__):
* Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner._load_plan_data):
*
Tools/Scripts/webkitpy/benchmark_runner/data/patches/extra/MotionMark1.3-15FPS.patch:
Added.
* Tools/Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.3-15fps.plan:
Added.
* Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
(BrowserPerfDashRunner._get_test_version_string): Include the imported plan
into the hash-version calculation-
Canonical link: https://commits.webkit.org/280660@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
